Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1868783002: Minor cleanup. (Closed)

Created:
4 years, 8 months ago by siva
Modified:
4 years, 8 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : code-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 8 months ago (2016-04-06 22:18:43 UTC) #2
hausner
LGTM w/suggestion https://codereview.chromium.org/1868783002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1868783002/diff/1/runtime/vm/object.cc#newcode10899 runtime/vm/object.cc:10899: String& cname = String::Handle(zone); cname looks very ...
4 years, 8 months ago (2016-04-06 22:27:19 UTC) #3
siva
https://codereview.chromium.org/1868783002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1868783002/diff/1/runtime/vm/object.cc#newcode10899 runtime/vm/object.cc:10899: String& cname = String::Handle(zone); On 2016/04/06 22:27:19, hausner wrote: ...
4 years, 8 months ago (2016-04-06 23:02:49 UTC) #4
siva
4 years, 8 months ago (2016-04-06 23:03:32 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
95f37e03afcc58ce035d5587cffc5fe57f0232ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698