components/omnibox/browser/keyword_provider_unittest.cc - Issue 1868763002: Remove URLRequest::IsHandledProtocol and IsHandledURL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/keyword_provider_unittest.cc

Issue 1868763002: Remove URLRequest::IsHandledProtocol and IsHandledURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: finish removing URLRequest::IsHandledProtocol() Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/net/aw_url_request_job_factory.cc ('K') | « components/omnibox/browser/autocomplete_provider_unittest.cc ('k') | components/omnibox/browser/test_scheme_classifier.cc » ('j') | content/browser/child_process_security_policy_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/keyword_provider_unittest.cc

diff --git a/components/omnibox/browser/keyword_provider_unittest.cc b/components/omnibox/browser/keyword_provider_unittest.cc

index 95c913d1934f9e119db103bfa90d51413e347575..04502adadf2c10f5662b88bded613a989565c75f 100644

--- a/components/omnibox/browser/keyword_provider_unittest.cc

+++ b/components/omnibox/browser/keyword_provider_unittest.cc

@@ -25,6 +25,7 @@

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "url/gurl.h"

+#include "url/url_constants.h"

using base::ASCIIToUTF16;

@@ -34,8 +35,10 @@ class TestingSchemeClassifier : public AutocompleteSchemeClassifier {

public:

metrics::OmniboxInputType::Type GetInputTypeForScheme(

const std::string& scheme) const override {

- if (net::URLRequest::IsHandledProtocol(scheme))

+ if (scheme == url::kHttpScheme || scheme == url::kHttpsScheme ||

+ scheme == url::kWsScheme || scheme == url::kWssScheme) {

return metrics::OmniboxInputType::URL;

+ }

return metrics::OmniboxInputType::INVALID;

}

};