Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1641)

Unified Diff: net/url_request/url_request.cc

Issue 1868763002: Remove URLRequest::IsHandledProtocol and IsHandledURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: replace some hardcoded strings Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index d6582e3404ea13ab1d708a1502e27cf70973ffb3..8dc12b44b4fb1844cc36663850ad52a0068e4263 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -429,21 +429,13 @@ void URLRequest::SetDefaultCookiePolicyToBlock() {
g_default_can_use_cookies = false;
}
+// TODO(mgersh): remove this and fix remaining callers once HttpProtocolHandler
+// exists
// static
bool URLRequest::IsHandledProtocol(const std::string& scheme) {
return URLRequestJobManager::SupportsScheme(scheme);
}
-// static
-bool URLRequest::IsHandledURL(const GURL& url) {
- if (!url.is_valid()) {
- // We handle error cases.
- return true;
- }
-
- return IsHandledProtocol(url.scheme());
-}
-
void URLRequest::set_first_party_for_cookies(
const GURL& first_party_for_cookies) {
DCHECK(!is_pending_);

Powered by Google App Engine
This is Rietveld 408576698