Remove URLRequest::IsHandledProtocol and IsHandledURL

android_webview/browser/net/aw_url_request_job_factory.cc

Index: android_webview/browser/net/aw_url_request_job_factory.cc
diff --git a/android_webview/browser/net/aw_url_request_job_factory.cc b/android_webview/browser/net/aw_url_request_job_factory.cc
index a13a8cbe3cd592c146ffa6c7509fd670c28743e5..fef48615c715d29ad23ec48af0b5590147fd8a4f 100644
--- a/android_webview/browser/net/aw_url_request_job_factory.cc
+++ b/android_webview/browser/net/aw_url_request_job_factory.cc
@@ -49,8 +49,11 @@ URLRequestJob* AwURLRequestJobFactory::MaybeCreateJobWithProtocolHandler(
   if (job)
     return job;
 
-  // If URLRequest supports the scheme NULL should be returned from this method.
+  // If a URLRequestJobManager built-in factory supports the scheme, NULL should
+  // be returned from this method.
   // In that case the built in handlers will then be used to create the job.
+  // TODO(mgersh): remove this check once HttpProtocolHandler exists and is
+  // added to the relevant URLRequestJobFactory.
   // NOTE(joth): See the assumption in IsHandledProtocol above.
   if (net::URLRequest::IsHandledProtocol(scheme))

[mmenke, 2016/04/21 18:24:19]

Can't this just be replaced with next_factory_->IsHandledProtocol(scheme)?  Note
that will make it URLRequestJobManager::SupportsScheme() as well as checking
schemes the URLRequestFactory supports itself.  The layering is a little weird. 
The JobManager is above the Factory when it comes to creating Jobs, but below it
when it comes to IsHandledProtocol, but that line should work now, and should
continue to work after the JobManager is removed.

[mgersh, 2016/04/21 19:04:45]

Oh, yeah, that would work. Did that, and also removed
URLRequest::IsHandledProtocol() entirely since this was the last caller.

     return NULL;