Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: components/omnibox/browser/test_scheme_classifier.cc

Issue 1868763002: Remove URLRequest::IsHandledProtocol and IsHandledURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase (needs fixing) Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/test_scheme_classifier.cc
diff --git a/components/omnibox/browser/test_scheme_classifier.cc b/components/omnibox/browser/test_scheme_classifier.cc
index 9e7b8acf594d30ba240188650d9afcf31cacd03d..8a001195138ec0d5905dae516e1a908e8e5e412b 100644
--- a/components/omnibox/browser/test_scheme_classifier.cc
+++ b/components/omnibox/browser/test_scheme_classifier.cc
@@ -18,15 +18,23 @@ metrics::OmniboxInputType::Type TestSchemeClassifier::GetInputTypeForScheme(
const std::string& scheme) const {
// This doesn't check the preference but check some chrome-ish schemes.
const char* kKnownURLSchemes[] = {
- url::kFileScheme, url::kAboutScheme, url::kFtpScheme, url::kBlobScheme,
- url::kFileSystemScheme, "view-source", "javascript", "chrome", "chrome-ui",
+ url::kFileScheme,
+ url::kAboutScheme,
+ url::kFtpScheme,
+ url::kBlobScheme,
+ url::kFileSystemScheme,
+ "view-source",
+ "javascript",
+ "chrome",
+ "chrome-ui",
+ url::kHttpScheme,
+ url::kHttpsScheme,
+ url::kWsScheme,
+ url::kWssScheme,
};
for (size_t i = 0; i < arraysize(kKnownURLSchemes); ++i) {
if (scheme == kKnownURLSchemes[i])
return metrics::OmniboxInputType::URL;
}
- if (net::URLRequest::IsHandledProtocol(scheme))
- return metrics::OmniboxInputType::URL;
-
return metrics::OmniboxInputType::INVALID;
}
« no previous file with comments | « components/omnibox/browser/keyword_provider_unittest.cc ('k') | content/browser/child_process_security_policy_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698