Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2932)

Unified Diff: android_webview/browser/net/aw_url_request_job_factory.cc

Issue 1868763002: Remove URLRequest::IsHandledProtocol and IsHandledURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase (needs fixing) Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/aw_content_browser_client.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/net/aw_url_request_job_factory.cc
diff --git a/android_webview/browser/net/aw_url_request_job_factory.cc b/android_webview/browser/net/aw_url_request_job_factory.cc
index a13a8cbe3cd592c146ffa6c7509fd670c28743e5..0d8ddecff1c11e981f5752df85d339c92007f3db 100644
--- a/android_webview/browser/net/aw_url_request_job_factory.cc
+++ b/android_webview/browser/net/aw_url_request_job_factory.cc
@@ -49,10 +49,13 @@ URLRequestJob* AwURLRequestJobFactory::MaybeCreateJobWithProtocolHandler(
if (job)
return job;
- // If URLRequest supports the scheme NULL should be returned from this method.
+ // If a URLRequestJobManager built-in factory supports the scheme, NULL should
+ // be returned from this method.
// In that case the built in handlers will then be used to create the job.
+ // TODO(mgersh): remove this check once HttpProtocolHandler exists and is
+ // added to the relevant URLRequestJobFactory.
// NOTE(joth): See the assumption in IsHandledProtocol above.
- if (net::URLRequest::IsHandledProtocol(scheme))
+ if (next_factory_->IsHandledProtocol(scheme))
return NULL;
return new net::URLRequestErrorJob(
« no previous file with comments | « android_webview/browser/aw_content_browser_client.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698