Remove URLRequest::IsHandledProtocol and IsHandledURL

android_webview/browser/net/aw_url_request_job_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/net/aw_url_request_job_factory.h"
 
 #include <utility>
 
 #include "net/base/net_errors.h"
 #include "net/url_request/url_request_error_job.h"
@@ skipping 31 matching lines @@
 URLRequestJob* AwURLRequestJobFactory::MaybeCreateJobWithProtocolHandler(
     const std::string& scheme,
     URLRequest* request,
     NetworkDelegate* network_delegate) const {
   URLRequestJob* job = next_factory_->MaybeCreateJobWithProtocolHandler(
       scheme, request, network_delegate);
 
   if (job)
     return job;
 
-  // If URLRequest supports the scheme NULL should be returned from this method.
+  // If a URLRequestJobManager built-in factory supports the scheme, NULL should
+  // be returned from this method.
   // In that case the built in handlers will then be used to create the job.
+  // TODO(mgersh): remove this check once HttpProtocolHandler exists and is
+  // added to the relevant URLRequestJobFactory.

[mmenke, 2016/04/21 19:13:33]

Think you can remove this TODO?  We'll have to keep this check, because of the
AwURLRequestJobFactory::IsHandledProtocol weirdness.

[mgersh, 2016/04/22 14:33:18]

My understanding is that it's here only to allow the fall-through to the
URLRequestJobManager built-in factories, which is why it was originally
URLRequest::IsHandledProtocol(), and it won't be needed anymore once everything
is a ProtocolHandler. I actually ended up removing it in the other CL.

[mmenke, 2016/04/22 14:54:36]

I thought it was also here to distinguished "handled" but not intercepted
(ERR_FAILED) with unknown schemes (ERR_UNKNOWN_SCHEME).  I guess your other CL
removes that distinction, on AW only?

[mmenke, 2016/04/22 14:56:00]

Oh, I guess with that logic moved down to URLRequestJobFactoryImpl, we still get
that behavior on AW, too.

   // NOTE(joth): See the assumption in IsHandledProtocol above.
-  if (net::URLRequest::IsHandledProtocol(scheme))
+  if (next_factory_->IsHandledProtocol(scheme))
     return NULL;

[mmenke, 2016/04/21 19:13:33]

nit:  While you're here, mind changing the NULL to nullptr?

[mgersh, 2016/04/22 14:33:18]

Not going to bother here, since I still think it can be deleted in the next CL.
I'll fix it if I do end up keeping it.

 
   return new net::URLRequestErrorJob(
       request, network_delegate, net::ERR_UNKNOWN_URL_SCHEME);
 }
 
 net::URLRequestJob* AwURLRequestJobFactory::MaybeInterceptRedirect(
      net::URLRequest* request,
      net::NetworkDelegate* network_delegate,
      const GURL& location) const  {
    return next_factory_->MaybeInterceptRedirect(
@@ skipping 10 matching lines @@
     const std::string& scheme,
     std::unique_ptr<ProtocolHandler> protocol_handler) {
   return next_factory_->SetProtocolHandler(scheme, std::move(protocol_handler));
 }
 
 bool AwURLRequestJobFactory::IsSafeRedirectTarget(const GURL& location) const {
   return next_factory_->IsSafeRedirectTarget(location);
 }
 
 } // namespace android_webview