Issue 186873002: [Android] RTL layout direction function clean up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 186873002: [Android] RTL layout direction function clean up. (Closed)

Created:
6 years, 9 months ago by Kibeom Kim (inactive)

Modified:
6 years, 9 months ago

Reviewers:
nyquist, newt (away)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] RTL layout direction function clean up. We used TextUtils#getLayoutDirectionFromLocale(Locale) function to get the layout direction, but Configuration#getLayoutDirection() is more correct function for our purpose. The result is the same. TBR=nyquist Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254858

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java	View		3 chunks	+4 lines, -6 lines	0 comments	Download
	M	ui/android/java/src/org/chromium/ui/base/LocalizationUtils.java	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Kibeom Kim (inactive)

The CQ bit was checked by kkimlabs@chromium.org

6 years, 9 months ago (2014-03-04 19:03:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/186873002/1

6 years, 9 months ago (2014-03-04 19:08:34 UTC) #4

Message was sent while issue was closed.

Change committed as 254858

Expand Messages | Collapse Messages