Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 1868723003: Add specialized rgba8888 unit sampler. (Closed)

Created:
4 years, 8 months ago by herb_g
Modified:
4 years, 8 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org, reed1, mtklein
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -3 lines) Patch
M src/core/SkLinearBitmapPipeline.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/core/SkLinearBitmapPipeline.cpp View 5 chunks +85 lines, -3 lines 2 comments Download

Messages

Total messages: 14 (7 generated)
herb_g
4 years, 8 months ago (2016-04-07 17:35:47 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868723003/1
4 years, 8 months ago (2016-04-07 21:41:14 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-07 21:51:25 UTC) #8
f(malita)
lgtm https://codereview.chromium.org/1868723003/diff/1/src/core/SkLinearBitmapPipeline.cpp File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1868723003/diff/1/src/core/SkLinearBitmapPipeline.cpp#newcode549 src/core/SkLinearBitmapPipeline.cpp:549: return &fSrc[fWidth * y + x]; Do we ...
4 years, 8 months ago (2016-04-08 12:58:13 UTC) #9
herb_g
https://codereview.chromium.org/1868723003/diff/1/src/core/SkLinearBitmapPipeline.cpp File src/core/SkLinearBitmapPipeline.cpp (right): https://codereview.chromium.org/1868723003/diff/1/src/core/SkLinearBitmapPipeline.cpp#newcode549 src/core/SkLinearBitmapPipeline.cpp:549: return &fSrc[fWidth * y + x]; On 2016/04/08 12:58:12, ...
4 years, 8 months ago (2016-04-08 13:48:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868723003/1
4 years, 8 months ago (2016-04-08 13:49:08 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 13:50:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6a5d7139ff17a2dfdf136de35f7dd9c94c1f648b

Powered by Google App Engine
This is Rietveld 408576698