Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1868723002: Allow location of test_runner.py to be overriden in GYP (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow location of test_runner.py to be overriden in GYP Required for webrtc BUG=599919 Committed: https://crrev.com/a490637d06294d400b0e6496642fc2fbcc974538 Cr-Commit-Position: refs/heads/master@{#385563}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/android/gyp/create_test_runner_script.py View 2 chunks +3 lines, -1 line 0 comments Download
M build/android/test_runner.gypi View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agrieve
On 2016/04/06 19:56:02, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org 🎹
4 years, 8 months ago (2016-04-06 19:56:11 UTC) #3
jbudorick
lgtm
4 years, 8 months ago (2016-04-06 20:00:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868723002/1
4 years, 8 months ago (2016-04-06 20:39:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 22:09:05 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 22:10:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a490637d06294d400b0e6496642fc2fbcc974538
Cr-Commit-Position: refs/heads/master@{#385563}

Powered by Google App Engine
This is Rietveld 408576698