| OLD | NEW |
| 1 // Copyright 2013 the V8 project authors. All rights reserved. | 1 // Copyright 2013 the V8 project authors. All rights reserved. |
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without |
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are |
| 4 // met: | 4 // met: |
| 5 // | 5 // |
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright |
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. |
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above |
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following |
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided |
| 11 // with the distribution. | 11 // with the distribution. |
| 12 // * Neither the name of Google Inc. nor the names of its | 12 // * Neither the name of Google Inc. nor the names of its |
| 13 // contributors may be used to endorse or promote products derived | 13 // contributors may be used to endorse or promote products derived |
| 14 // from this software without specific prior written permission. | 14 // from this software without specific prior written permission. |
| 15 // | 15 // |
| 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS |
| 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT |
| 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR |
| 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT |
| 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, |
| 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT |
| 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, |
| 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY |
| 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
| 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
| 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
| 27 // limitations under the License. | 27 // limitations under the License. |
| 28 | 28 |
| 29 #ifndef V8_EXTENSIONS_I18N_COLLATOR_H_ | 29 // Make sure normalization is always on, and normalization flag is ignored. |
| 30 #define V8_EXTENSIONS_I18N_COLLATOR_H_ | |
| 31 | 30 |
| 32 #include "unicode/uversion.h" | 31 // We need a character with two combining marks, from two different classes, |
| 33 #include "v8.h" | 32 // to make ICU fail comparison without normalization (upper, lower accent). |
| 33 // We will just switch order of combining characters to try to induce failure. |
| 34 | 34 |
| 35 namespace U_ICU_NAMESPACE { | 35 // FYI, this one wouldn't work, since both accents are from the same class: |
| 36 class Collator; | 36 // http://unicode.org/cldr/utility/character.jsp?a=01DF |
| 37 class UnicodeString; | |
| 38 } | |
| 39 | 37 |
| 40 namespace v8_i18n { | 38 // See http://demo.icu-project.org/icu-bin/nbrowser?t=&s=1E09&uv=0 and |
| 39 // http://unicode.org/cldr/utility/character.jsp?a=1E09 for character details. |
| 40 var toCompare = ['\u0063\u0327\u0301', '\u0063\u0301\u0327']; |
| 41 | 41 |
| 42 class Collator { | 42 // Try with normalization off (as an option). |
| 43 public: | 43 var collator = Intl.Collator([], {normalization: false}); |
| 44 static void JSCreateCollator(const v8::FunctionCallbackInfo<v8::Value>& args); | 44 // If we accepted normalization parameter, this would have failed. |
| 45 assertEquals(0, collator.compare(toCompare[0], toCompare[1])); |
| 46 assertFalse(collator.resolvedOptions().hasOwnProperty('normalization')); |
| 45 | 47 |
| 46 // Helper methods for various bindings. | 48 // Try with normalization off (as Unicode extension). |
| 49 collator = Intl.Collator(['de-u-kk-false']); |
| 50 // If we accepted normalization parameter, this would have failed. |
| 51 assertEquals(0, collator.compare(toCompare[0], toCompare[1])); |
| 52 assertFalse(collator.resolvedOptions().hasOwnProperty('normalization')); |
| 47 | 53 |
| 48 // Unpacks collator object from corresponding JavaScript object. | 54 // Normalization is on by default. |
| 49 static icu::Collator* UnpackCollator(v8::Handle<v8::Object> obj); | 55 collator = Intl.Collator(); |
| 50 | 56 assertEquals(0, collator.compare(toCompare[0], toCompare[1])); |
| 51 // Release memory we allocated for the Collator once the JS object that | 57 assertFalse(collator.resolvedOptions().hasOwnProperty('normalization')); |
| 52 // holds the pointer gets garbage collected. | |
| 53 static void DeleteCollator(v8::Isolate* isolate, | |
| 54 v8::Persistent<v8::Object>* object, | |
| 55 void* param); | |
| 56 | |
| 57 // Compare two strings and returns -1, 0 and 1 depending on | |
| 58 // whether string1 is smaller than, equal to or larger than string2. | |
| 59 static void JSInternalCompare( | |
| 60 const v8::FunctionCallbackInfo<v8::Value>& args); | |
| 61 | |
| 62 private: | |
| 63 Collator() {} | |
| 64 }; | |
| 65 | |
| 66 } // namespace v8_i18n | |
| 67 | |
| 68 #endif // V8_EXTENSIONS_I18N_COLLATOR_H_ | |
| OLD | NEW |