infra_libs/httplib2_utils.py - Issue 1868693002: ts_mon: catch more PubSub errors from socket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra_libs/httplib2_utils.py

Issue 1868693002: ts_mon: catch more PubSub errors from socket. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra_libs/httplib2_utils.py

diff --git a/infra_libs/httplib2_utils.py b/infra_libs/httplib2_utils.py

index ee5f6aed8b1ee0f99f49ccc88aee147d2a882ac6..fcb9fe387f5c52b8bf5a64eb6b4e578b229990dc 100644

--- a/infra_libs/httplib2_utils.py

+++ b/infra_libs/httplib2_utils.py

@@ -199,7 +199,7 @@ class InstrumentedHttp(httplib2.Http):

except socket.timeout:

self._update_metrics(http_metrics.STATUS_TIMEOUT, start_time)

raise

- except socket.error:

+ except (socket.error, socket.herror, socket.gaierror):

self._update_metrics(http_metrics.STATUS_ERROR, start_time)

raise

except httplib2.HttpLib2Error:

« no previous file with comments | « no previous file | infra_libs/ts_mon/common/monitors.py » ('j') | no next file with comments »