Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1868673002: TaskScheduler: Add PriorityQueue::Transaction::PushNoWakeUp(). (Closed)

Created:
4 years, 8 months ago by fdoray
Modified:
4 years, 8 months ago
Reviewers:
danakj, robliao, gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@tasktracker2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TaskScheduler: Add PriorityQueue::Transaction::PushNoWakeUp(). With this method, it is possible to push a Sequence into a PriorityQueue without invoking the wake up callback. BUG=553459 Committed: https://crrev.com/19d771360ca7e98660906a89deaa6223559f2f94 Cr-Commit-Position: refs/heads/master@{#386101}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -30 lines) Patch
M base/task_scheduler/priority_queue.h View 3 chunks +18 lines, -10 lines 0 comments Download
M base/task_scheduler/priority_queue.cc View 3 chunks +21 lines, -13 lines 0 comments Download
M base/task_scheduler/priority_queue_unittest.cc View 3 chunks +101 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
fdoray
4 years, 8 months ago (2016-04-06 19:31:17 UTC) #2
danakj
LGTM
4 years, 8 months ago (2016-04-06 19:40:45 UTC) #5
robliao
lgtm
4 years, 8 months ago (2016-04-06 19:48:00 UTC) #6
gab
lgtm
4 years, 8 months ago (2016-04-07 15:51:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868673002/20001
4 years, 8 months ago (2016-04-08 15:42:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-08 16:53:45 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 16:54:42 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/19d771360ca7e98660906a89deaa6223559f2f94
Cr-Commit-Position: refs/heads/master@{#386101}

Powered by Google App Engine
This is Rietveld 408576698