Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1868663002: Update worker mode to use the bazel protos directly instead of json (Closed)

Created:
4 years, 8 months ago by jakemac
Modified:
4 years, 8 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update worker mode to use the bazel protos directly instead of json BUG= R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/92419d092be6c80a07347930a73b8ee2ee5951ba

Patch Set 1 #

Patch Set 2 : remove hack in resynthesize.dart #

Patch Set 3 : Cleanup #

Patch Set 4 : remove dep on async #

Total comments: 2

Patch Set 5 : added MessageGrouper test #

Patch Set 6 : s/setInputBytes/addInputBytes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+525 lines, -399 lines) Patch
M DEPS View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 2 7 chunks +37 lines, -184 lines 0 comments Download
A pkg/analyzer_cli/lib/src/message_grouper.dart View 1 chunk +112 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/lib/src/worker_protocol.pb.dart View 1 chunk +133 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/pubspec.yaml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_cli/test/all.dart View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/test/build_mode_test.dart View 1 2 3 4 5 2 chunks +72 lines, -215 lines 0 comments Download
A pkg/analyzer_cli/test/message_grouper_test.dart View 1 2 3 4 5 1 chunk +123 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/test/utils.dart View 1 2 3 4 5 3 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jakemac
4 years, 8 months ago (2016-04-06 19:28:12 UTC) #2
Paul Berry
lgtm, with one minor nit. https://codereview.chromium.org/1868663002/diff/60001/pkg/analyzer_cli/test/build_mode_test.dart File pkg/analyzer_cli/test/build_mode_test.dart (right): https://codereview.chromium.org/1868663002/diff/60001/pkg/analyzer_cli/test/build_mode_test.dart#newcode134 pkg/analyzer_cli/test/build_mode_test.dart:134: pendingBytes.add(-1); It seems like ...
4 years, 8 months ago (2016-04-06 19:54:19 UTC) #3
jakemac
https://codereview.chromium.org/1868663002/diff/60001/pkg/analyzer_cli/test/build_mode_test.dart File pkg/analyzer_cli/test/build_mode_test.dart (right): https://codereview.chromium.org/1868663002/diff/60001/pkg/analyzer_cli/test/build_mode_test.dart#newcode134 pkg/analyzer_cli/test/build_mode_test.dart:134: pendingBytes.add(-1); On 2016/04/06 19:54:19, Paul Berry wrote: > It ...
4 years, 8 months ago (2016-04-06 20:18:30 UTC) #4
Paul Berry
lgtm as of patch set 6
4 years, 8 months ago (2016-04-06 20:24:20 UTC) #5
jakemac
4 years, 8 months ago (2016-04-06 20:50:01 UTC) #7
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
92419d092be6c80a07347930a73b8ee2ee5951ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698