Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 1868603005: Remove GOMA_PING_TIMEOUT_SEC and GOMA_PING_RETRY_INTERVAL. (Closed)

Created:
4 years, 8 months ago by Yoshisato Yanagisawa
Modified:
4 years, 8 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Remove GOMA_PING_TIMEOUT_SEC and GOMA_PING_RETRY_INTERVAL. Since large enough value are set by default from goma client version 103, we do not need to set them here. BUG=595816 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M scripts/slave/compile.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Yoshisato Yanagisawa
4 years, 8 months ago (2016-04-07 07:04:35 UTC) #2
Paweł Hajdan Jr.
LGTM
4 years, 8 months ago (2016-04-07 10:54:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868603005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868603005/1
4 years, 8 months ago (2016-04-08 02:54:00 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 02:59:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299788

Powered by Google App Engine
This is Rietveld 408576698