Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1868593003: [Template expressions] font-family needs to be i18nRaw for mac/win quoted fonts (Closed)

Created:
4 years, 8 months ago by dschuyler
Modified:
4 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Template expressions] font-family needs to be i18nRaw for mac/win quoted fonts Font-family css may now have quoted font names. BUG=601051 Committed: https://crrev.com/3c53b2ab34cde861beab8e9a88ba71414d410c7e Cr-Commit-Position: refs/heads/master@{#385609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/webui/resources/css/text_defaults.css View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/webui/resources/css/text_defaults_md.css View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dschuyler
4 years, 8 months ago (2016-04-06 19:09:16 UTC) #2
Dan Beam
is there a way we could write a test for this?
4 years, 8 months ago (2016-04-06 19:11:04 UTC) #3
Dan Beam
lgtm in good faith
4 years, 8 months ago (2016-04-06 19:11:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868593003/1
4 years, 8 months ago (2016-04-07 00:59:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 01:06:59 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 01:08:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c53b2ab34cde861beab8e9a88ba71414d410c7e
Cr-Commit-Position: refs/heads/master@{#385609}

Powered by Google App Engine
This is Rietveld 408576698