Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: tools/perf/benchmarks/benchmark_smoke_unittest.py

Issue 1868593002: [Telemetry] Reenable tracing.tracing_with_debug_overhead benchmark & disable its smoke test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/benchmarks/tracing.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run the first page of one benchmark for every module. 5 """Run the first page of one benchmark for every module.
6 6
7 Only benchmarks that have a composable measurement are included. 7 Only benchmarks that have a composable measurement are included.
8 Ideally this test would be comprehensive, however, running one page 8 Ideally this test would be comprehensive, however, running one page
9 of every benchmark would run impractically long. 9 of every benchmark would run impractically long.
10 """ 10 """
(...skipping 12 matching lines...) Expand all
23 from benchmarks import jetstream 23 from benchmarks import jetstream
24 from benchmarks import kraken 24 from benchmarks import kraken
25 from benchmarks import memory 25 from benchmarks import memory
26 from benchmarks import octane 26 from benchmarks import octane
27 from benchmarks import rasterize_and_record_micro 27 from benchmarks import rasterize_and_record_micro
28 from benchmarks import repaint 28 from benchmarks import repaint
29 from benchmarks import spaceport 29 from benchmarks import spaceport
30 from benchmarks import speedometer 30 from benchmarks import speedometer
31 from benchmarks import sunspider 31 from benchmarks import sunspider
32 from benchmarks import text_selection 32 from benchmarks import text_selection
33 from benchmarks import tracing
33 34
34 35
35 def SmokeTestGenerator(benchmark): 36 def SmokeTestGenerator(benchmark):
36 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. 37 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST.
37 # 38 #
38 # This smoke test dynamically tests all benchmarks. So disabling it for one 39 # This smoke test dynamically tests all benchmarks. So disabling it for one
39 # failing or flaky benchmark would disable a much wider swath of coverage 40 # failing or flaky benchmark would disable a much wider swath of coverage
40 # than is usally intended. Instead, if a particular benchmark is failing, 41 # than is usally intended. Instead, if a particular benchmark is failing,
41 # disable it in tools/perf/benchmarks/*. 42 # disable it in tools/perf/benchmarks/*.
42 @benchmark_module.Disabled('chromeos') # crbug.com/351114 43 @benchmark_module.Disabled('chromeos') # crbug.com/351114
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 _BLACK_LIST_TEST_MODULES = { 80 _BLACK_LIST_TEST_MODULES = {
80 image_decoding, # Always fails on Mac10.9 Tests builder. 81 image_decoding, # Always fails on Mac10.9 Tests builder.
81 indexeddb_perf, # Always fails on Win7 & Android Tests builder. 82 indexeddb_perf, # Always fails on Win7 & Android Tests builder.
82 octane, # Often fails & take long time to timeout on cq bot. 83 octane, # Often fails & take long time to timeout on cq bot.
83 rasterize_and_record_micro, # Always fails on cq bot. 84 rasterize_and_record_micro, # Always fails on cq bot.
84 repaint, # Often fails & takes long time to timeout on cq bot. 85 repaint, # Often fails & takes long time to timeout on cq bot.
85 spaceport, # Takes 451 seconds. 86 spaceport, # Takes 451 seconds.
86 speedometer, # Takes 101 seconds. 87 speedometer, # Takes 101 seconds.
87 jetstream, # Take 206 seconds. 88 jetstream, # Take 206 seconds.
88 text_selection, # Always fails on cq bot. 89 text_selection, # Always fails on cq bot.
89 memory # Flaky on bots, crbug.com/513767 90 memory # Flaky on bots, crbug.com/513767.
90 } 91 }
91 92
92 # Some smoke benchmark tests that run quickly on desktop platform can be very 93 # Some smoke benchmark tests that run quickly on desktop platform can be very
93 # slow on Android. So we create a separate set of black list only for Android. 94 # slow on Android. So we create a separate set of black list only for Android.
94 _ANDROID_BLACK_LIST_MODULES = { 95 _ANDROID_BLACK_LIST_MODULES = {
95 kraken, # Takes 275 seconds on Android. 96 kraken, # Takes 275 seconds on Android.
96 sunspider, # Takes 163 seconds on Android. 97 sunspider, # Takes 163 seconds on Android.
98 tracing, # Failed on Android bot, crbug.com/600989.
97 } 99 }
98 100
99 101
100 def load_tests(loader, standard_tests, pattern): 102 def load_tests(loader, standard_tests, pattern):
101 del loader, standard_tests, pattern # unused 103 del loader, standard_tests, pattern # unused
102 suite = progress_reporter.TestSuite() 104 suite = progress_reporter.TestSuite()
103 105
104 benchmarks_dir = os.path.dirname(__file__) 106 benchmarks_dir = os.path.dirname(__file__)
105 top_level_dir = os.path.dirname(benchmarks_dir) 107 top_level_dir = os.path.dirname(benchmarks_dir)
106 108
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 149
148 # TODO(bashi): Remove once crrev.com/1266833004 is landed. 150 # TODO(bashi): Remove once crrev.com/1266833004 is landed.
149 if benchmark.Name() == 'memory.blink_memory_mobile': 151 if benchmark.Name() == 'memory.blink_memory_mobile':
150 method._disabled_strings.add('android') 152 method._disabled_strings.add('android')
151 153
152 setattr(BenchmarkSmokeTest, benchmark.Name(), method) 154 setattr(BenchmarkSmokeTest, benchmark.Name(), method)
153 155
154 suite.addTest(BenchmarkSmokeTest(benchmark.Name())) 156 suite.addTest(BenchmarkSmokeTest(benchmark.Name()))
155 157
156 return suite 158 return suite
OLDNEW
« no previous file with comments | « no previous file | tools/perf/benchmarks/tracing.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698