Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1868563002:
GN: Fix iOS build for BoringSSL (Closed)
|
Created:
4 years, 8 months ago by kjellander_chromium Modified:
4 years, 8 months ago CC:
chromium-reviews Base URL:
http://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionGN: Fix iOS build for BoringSSL
When generating ninja files with GN for WebRTC, this error is produced:
$ gn gen --args="target_os=\"ios\"" out/Default
ERROR at //third_party/boringssl/BUILD.gn:86:9: Undefined variable for +=.
defines += [ "OPENSSL_NO_ASM" ]
^------
I don't have something with this name in scope now.
Chromium doesn't use BoringSSL for iOS and there are no iOS GN bots in
https://build.chromium.org/p/client.boringssl/waterfall
which is probably why this has gone unnoticed so far.
BUG=webrtc:5195
Committed: https://crrev.com/03164f2a6403a28c6d4c1f4b71512f242ea102f7
Cr-Commit-Position: refs/heads/master@{#385684}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
kjellander@chromium.org changed reviewers: + agl@chromium.org
The CQ bit was checked by kjellander@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868563002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from
==========
GN: Fix iOS build for BoringSSL
When generating ninja files with GN for WebRTC, this error is produced:
$ gn gen --args="target_os=\"ios\"" out/Default
ERROR at //third_party/boringssl/BUILD.gn:86:9: Undefined variable for +=.
defines += [ "OPENSSL_NO_ASM" ]
^------
I don't have something with this name in scope now.
Chromium doesn't use BoringSSL for iOS and there are no iOS GN bots in
https://build.chromium.org/p/client.boringssl/waterfall
which is probably why this has gone unnoticed so far.
BUG=webrtc:5195
==========
to
==========
GN: Fix iOS build for BoringSSL
When generating ninja files with GN for WebRTC, this error is produced:
$ gn gen --args="target_os=\"ios\"" out/Default
ERROR at //third_party/boringssl/BUILD.gn:86:9: Undefined variable for +=.
defines += [ "OPENSSL_NO_ASM" ]
^------
I don't have something with this name in scope now.
Chromium doesn't use BoringSSL for iOS and there are no iOS GN bots in
https://build.chromium.org/p/client.boringssl/waterfall
which is probably why this has gone unnoticed so far.
BUG=webrtc:5195
==========
agl@chromium.org changed reviewers: + davidben@chromium.org - agl@chromium.org
agl@chromium.org changed reviewers: + agl@chromium.org
LGTM Oh, davidben is away too. I see no reason to block this.
lgtm
The CQ bit was checked by kjellander@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868563002/1
Message was sent while issue was closed.
Description was changed from
==========
GN: Fix iOS build for BoringSSL
When generating ninja files with GN for WebRTC, this error is produced:
$ gn gen --args="target_os=\"ios\"" out/Default
ERROR at //third_party/boringssl/BUILD.gn:86:9: Undefined variable for +=.
defines += [ "OPENSSL_NO_ASM" ]
^------
I don't have something with this name in scope now.
Chromium doesn't use BoringSSL for iOS and there are no iOS GN bots in
https://build.chromium.org/p/client.boringssl/waterfall
which is probably why this has gone unnoticed so far.
BUG=webrtc:5195
==========
to
==========
GN: Fix iOS build for BoringSSL
When generating ninja files with GN for WebRTC, this error is produced:
$ gn gen --args="target_os=\"ios\"" out/Default
ERROR at //third_party/boringssl/BUILD.gn:86:9: Undefined variable for +=.
defines += [ "OPENSSL_NO_ASM" ]
^------
I don't have something with this name in scope now.
Chromium doesn't use BoringSSL for iOS and there are no iOS GN bots in
https://build.chromium.org/p/client.boringssl/waterfall
which is probably why this has gone unnoticed so far.
BUG=webrtc:5195
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
GN: Fix iOS build for BoringSSL
When generating ninja files with GN for WebRTC, this error is produced:
$ gn gen --args="target_os=\"ios\"" out/Default
ERROR at //third_party/boringssl/BUILD.gn:86:9: Undefined variable for +=.
defines += [ "OPENSSL_NO_ASM" ]
^------
I don't have something with this name in scope now.
Chromium doesn't use BoringSSL for iOS and there are no iOS GN bots in
https://build.chromium.org/p/client.boringssl/waterfall
which is probably why this has gone unnoticed so far.
BUG=webrtc:5195
==========
to
==========
GN: Fix iOS build for BoringSSL
When generating ninja files with GN for WebRTC, this error is produced:
$ gn gen --args="target_os=\"ios\"" out/Default
ERROR at //third_party/boringssl/BUILD.gn:86:9: Undefined variable for +=.
defines += [ "OPENSSL_NO_ASM" ]
^------
I don't have something with this name in scope now.
Chromium doesn't use BoringSSL for iOS and there are no iOS GN bots in
https://build.chromium.org/p/client.boringssl/waterfall
which is probably why this has gone unnoticed so far.
BUG=webrtc:5195
Committed: https://crrev.com/03164f2a6403a28c6d4c1f4b71512f242ea102f7
Cr-Commit-Position: refs/heads/master@{#385684}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/03164f2a6403a28c6d4c1f4b71512f242ea102f7 Cr-Commit-Position: refs/heads/master@{#385684} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
