Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 1868553005: alternate textblobgeometrychange fix... just make our own surface if needed (Closed)

Created:
4 years, 8 months ago by mtklein_C
Modified:
4 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

alternate textblobgeometrychange fix... just make our own surface if needed This should decopple fixing the replay modes from revising the API. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1868553005 Committed: https://skia.googlesource.com/skia/+/9e65f9399ea9d50dca723ca23c10ec4145b54abe

Patch Set 1 #

Patch Set 2 : update dm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -264 lines) Patch
M gm/textblobgeometrychange.cpp View 1 chunk +17 lines, -21 lines 0 comments Download
M tools/dm_flags.json View 1 30 chunks +0 lines, -240 lines 0 comments Download
M tools/dm_flags.py View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mtklein_C
4 years, 8 months ago (2016-04-06 20:47:55 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868553005/10001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868553005/10001
4 years, 8 months ago (2016-04-06 20:47:56 UTC) #5
reed1
lgtm
4 years, 8 months ago (2016-04-06 20:49:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868553005/10001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868553005/10001
4 years, 8 months ago (2016-04-06 20:51:34 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 20:57:41 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:10001) as
https://skia.googlesource.com/skia/+/9e65f9399ea9d50dca723ca23c10ec4145b54abe

Powered by Google App Engine
This is Rietveld 408576698