OLD | NEW |
(Empty) | |
| 1 # Copyright 2016 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is govered by a BSD-style |
| 3 # license that can be found in the LICENSE file or at |
| 4 # https://developers.google.com/open-source/licenses/bsd |
| 5 |
| 6 """Unit tests for the componentdetail servlet.""" |
| 7 |
| 8 import unittest |
| 9 |
| 10 import mox |
| 11 |
| 12 from features import filterrules_helpers |
| 13 from framework import permissions |
| 14 from proto import project_pb2 |
| 15 from services import service_manager |
| 16 from testing import fake |
| 17 from testing import testing_helpers |
| 18 from tracker import componentdetail |
| 19 from tracker import tracker_bizobj |
| 20 |
| 21 import webapp2 |
| 22 |
| 23 |
| 24 class ComponentDetailTest(unittest.TestCase): |
| 25 |
| 26 def setUp(self): |
| 27 self.services = service_manager.Services( |
| 28 user=fake.UserService(), |
| 29 issue=fake.IssueService(), |
| 30 config=fake.ConfigService(), |
| 31 project=fake.ProjectService()) |
| 32 self.servlet = componentdetail.ComponentDetail( |
| 33 'req', 'res', services=self.services) |
| 34 self.project = self.services.project.TestAddProject('proj') |
| 35 self.mr = testing_helpers.MakeMonorailRequest( |
| 36 project=self.project, perms=permissions.OWNER_ACTIVE_PERMISSIONSET) |
| 37 self.mr.auth.email = 'b@example.com' |
| 38 self.config = self.services.config.GetProjectConfig( |
| 39 'fake cnxn', self.project.project_id) |
| 40 self.services.config.StoreConfig('fake cnxn', self.config) |
| 41 self.cd = tracker_bizobj.MakeComponentDef( |
| 42 1, self.project.project_id, 'BackEnd', 'doc', False, [], [111L], 100000, |
| 43 122L, 10000000, 133L) |
| 44 self.config.component_defs = [self.cd] |
| 45 self.services.user.TestAddUser('a@example.com', 111L) |
| 46 self.services.user.TestAddUser('b@example.com', 122L) |
| 47 self.services.user.TestAddUser('c@example.com', 133L) |
| 48 self.mr.component_path = 'BackEnd' |
| 49 |
| 50 self.mox = mox.Mox() |
| 51 |
| 52 def tearDown(self): |
| 53 self.mox.UnsetStubs() |
| 54 self.mox.ResetAll() |
| 55 |
| 56 def testGetComponentDef_NotFound(self): |
| 57 self.mr.component_path = 'NeverHeardOfIt' |
| 58 self.assertRaises( |
| 59 webapp2.HTTPException, |
| 60 self.servlet._GetComponentDef, self.mr) |
| 61 |
| 62 def testGetComponentDef_Normal(self): |
| 63 actual_config, actual_cd = self.servlet._GetComponentDef(self.mr) |
| 64 self.assertEqual(self.config, actual_config) |
| 65 self.assertEqual(self.cd, actual_cd) |
| 66 |
| 67 def testAssertBasePermission_AnyoneCanView(self): |
| 68 self.servlet.AssertBasePermission(self.mr) |
| 69 self.mr.perms = permissions.COMMITTER_ACTIVE_PERMISSIONSET |
| 70 self.servlet.AssertBasePermission(self.mr) |
| 71 self.mr.perms = permissions.CONTRIBUTOR_ACTIVE_PERMISSIONSET |
| 72 self.servlet.AssertBasePermission(self.mr) |
| 73 self.mr.perms = permissions.READ_ONLY_PERMISSIONSET |
| 74 self.servlet.AssertBasePermission(self.mr) |
| 75 |
| 76 def testAssertBasePermission_MembersOnly(self): |
| 77 self.project.access = project_pb2.ProjectAccess.MEMBERS_ONLY |
| 78 # The project members can view the component definition. |
| 79 self.servlet.AssertBasePermission(self.mr) |
| 80 self.mr.perms = permissions.COMMITTER_ACTIVE_PERMISSIONSET |
| 81 self.servlet.AssertBasePermission(self.mr) |
| 82 self.mr.perms = permissions.CONTRIBUTOR_ACTIVE_PERMISSIONSET |
| 83 self.servlet.AssertBasePermission(self.mr) |
| 84 # Non-member is not allowed to view anything in the project. |
| 85 self.mr.perms = permissions.EMPTY_PERMISSIONSET |
| 86 self.assertRaises( |
| 87 permissions.PermissionException, |
| 88 self.servlet.AssertBasePermission, self.mr) |
| 89 |
| 90 def testGatherPageData_ReadWrite(self): |
| 91 page_data = self.servlet.GatherPageData(self.mr) |
| 92 self.assertEqual(self.servlet.PROCESS_TAB_COMPONENTS, |
| 93 page_data['admin_tab_mode']) |
| 94 self.assertTrue(page_data['allow_edit']) |
| 95 self.assertEqual([], page_data['initial_admins']) |
| 96 component_def_view = page_data['component_def'] |
| 97 self.assertEqual('BackEnd', component_def_view.path) |
| 98 |
| 99 def testGatherPageData_ReadOnly(self): |
| 100 self.mr.perms = permissions.READ_ONLY_PERMISSIONSET |
| 101 page_data = self.servlet.GatherPageData(self.mr) |
| 102 self.assertEqual(self.servlet.PROCESS_TAB_COMPONENTS, |
| 103 page_data['admin_tab_mode']) |
| 104 self.assertFalse(page_data['allow_edit']) |
| 105 self.assertFalse(page_data['allow_delete']) |
| 106 self.assertEqual([], page_data['initial_admins']) |
| 107 component_def_view = page_data['component_def'] |
| 108 self.assertEqual('BackEnd', component_def_view.path) |
| 109 |
| 110 def testGatherPageData_ObscuredCreatorModifier(self): |
| 111 page_data = self.servlet.GatherPageData(self.mr) |
| 112 |
| 113 self.assertEqual('b...@example.com', page_data['creator'].display_name) |
| 114 self.assertEqual('/u/122/', page_data['creator'].profile_url) |
| 115 self.assertEqual('Jan 1970', page_data['created']) |
| 116 self.assertEqual('c...@example.com', page_data['modifier'].display_name) |
| 117 self.assertEqual('/u/133/', page_data['modifier'].profile_url) |
| 118 self.assertEqual('Apr 1970', page_data['modified']) |
| 119 |
| 120 def testGatherPageData_VisibleCreatorModifierForAdmin(self): |
| 121 self.mr.auth.user_pb.is_site_admin = True |
| 122 page_data = self.servlet.GatherPageData(self.mr) |
| 123 |
| 124 self.assertEqual('b@example.com', page_data['creator'].display_name) |
| 125 self.assertEqual('/u/b@example.com/', page_data['creator'].profile_url) |
| 126 self.assertEqual('Jan 1970', page_data['created']) |
| 127 self.assertEqual('c@example.com', page_data['modifier'].display_name) |
| 128 self.assertEqual('/u/c@example.com/', page_data['modifier'].profile_url) |
| 129 self.assertEqual('Apr 1970', page_data['modified']) |
| 130 |
| 131 def testGatherPageData_VisibleCreatorForSelf(self): |
| 132 self.mr.auth.user_id = 122L |
| 133 page_data = self.servlet.GatherPageData(self.mr) |
| 134 |
| 135 self.assertEqual('b@example.com', page_data['creator'].display_name) |
| 136 self.assertEqual('/u/b@example.com/', page_data['creator'].profile_url) |
| 137 self.assertEqual('Jan 1970', page_data['created']) |
| 138 # Modifier should still be obscured. |
| 139 self.assertEqual('c...@example.com', page_data['modifier'].display_name) |
| 140 self.assertEqual('/u/133/', page_data['modifier'].profile_url) |
| 141 self.assertEqual('Apr 1970', page_data['modified']) |
| 142 |
| 143 def testGatherPageData_VisibleCreatorModifierForUnobscuredEmail(self): |
| 144 creator = self.services.user.GetUser(self.mr.cnxn, 122L) |
| 145 creator.obscure_email = False |
| 146 modifier = self.services.user.GetUser(self.mr.cnxn, 133L) |
| 147 modifier.obscure_email = False |
| 148 page_data = self.servlet.GatherPageData(self.mr) |
| 149 |
| 150 self.assertEqual('b@example.com', page_data['creator'].display_name) |
| 151 self.assertEqual('/u/b@example.com/', page_data['creator'].profile_url) |
| 152 self.assertEqual('Jan 1970', page_data['created']) |
| 153 self.assertEqual('c@example.com', page_data['modifier'].display_name) |
| 154 self.assertEqual('/u/c@example.com/', page_data['modifier'].profile_url) |
| 155 self.assertEqual('Apr 1970', page_data['modified']) |
| 156 |
| 157 def testGatherPageData_WithSubComponents(self): |
| 158 subcd = tracker_bizobj.MakeComponentDef( |
| 159 2, self.project.project_id, 'BackEnd>Worker', 'doc', False, [], [111L], |
| 160 0, 122L) |
| 161 self.config.component_defs.append(subcd) |
| 162 page_data = self.servlet.GatherPageData(self.mr) |
| 163 self.assertFalse(page_data['allow_delete']) |
| 164 self.assertEqual([subcd], page_data['subcomponents']) |
| 165 |
| 166 def testGatherPageData_WithTemplates(self): |
| 167 self.services.config.component_ids_to_templates[self.cd.component_id] = [ |
| 168 'template'] |
| 169 page_data = self.servlet.GatherPageData(self.mr) |
| 170 self.assertFalse(page_data['allow_delete']) |
| 171 self.assertEqual(['template'], page_data['templates']) |
| 172 |
| 173 def testProcessFormData_Permission(self): |
| 174 """Only owners can edit components.""" |
| 175 mr = testing_helpers.MakeMonorailRequest( |
| 176 project=self.project, |
| 177 perms=permissions.CONTRIBUTOR_ACTIVE_PERMISSIONSET) |
| 178 mr.component_path = 'BackEnd' |
| 179 post_data = fake.PostData( |
| 180 name=['BackEnd'], |
| 181 deletecomponent=['Submit']) |
| 182 self.assertRaises(permissions.PermissionException, |
| 183 self.servlet.ProcessFormData, mr, post_data) |
| 184 |
| 185 self.servlet.ProcessFormData(self.mr, post_data) |
| 186 |
| 187 def testProcessFormData_Delete(self): |
| 188 post_data = fake.PostData( |
| 189 name=['BackEnd'], |
| 190 deletecomponent=['Submit']) |
| 191 url = self.servlet.ProcessFormData(self.mr, post_data) |
| 192 self.assertTrue('/adminComponents?deleted=1&' in url) |
| 193 self.assertIsNone( |
| 194 tracker_bizobj.FindComponentDef('BackEnd', self.config)) |
| 195 |
| 196 def testProcessFormData_Delete_WithSubComponent(self): |
| 197 subcd = tracker_bizobj.MakeComponentDef( |
| 198 2, self.project.project_id, 'BackEnd>Worker', 'doc', False, [], [111L], |
| 199 0, 122L) |
| 200 self.config.component_defs.append(subcd) |
| 201 |
| 202 post_data = fake.PostData( |
| 203 name=['BackEnd'], |
| 204 deletecomponent=['Submit']) |
| 205 try: |
| 206 self.servlet.ProcessFormData(self.mr, post_data) |
| 207 self.fail('Expected permissions.PermissionException') |
| 208 except permissions.PermissionException, e: |
| 209 self.assertEquals('User tried to delete component that had subcomponents', |
| 210 e.message) |
| 211 |
| 212 def testProcessFormData_Edit(self): |
| 213 post_data = fake.PostData( |
| 214 leaf_name=['BackEnd'], |
| 215 docstring=['This is where the magic happens'], |
| 216 deprecated=[True], |
| 217 admins=['a@example.com'], |
| 218 cc=['a@example.com']) |
| 219 |
| 220 url = self.servlet.ProcessFormData(self.mr, post_data) |
| 221 |
| 222 self.mox.VerifyAll() |
| 223 self.assertTrue('/components/detail?component=BackEnd&saved=1&' in url) |
| 224 config = self.services.config.GetProjectConfig( |
| 225 self.mr.cnxn, self.mr.project_id) |
| 226 |
| 227 cd = tracker_bizobj.FindComponentDef('BackEnd', config) |
| 228 self.assertEqual('BackEnd', cd.path) |
| 229 self.assertEqual( |
| 230 'This is where the magic happens', |
| 231 cd.docstring) |
| 232 self.assertEqual(True, cd.deprecated) |
| 233 self.assertEqual([111L], cd.admin_ids) |
| 234 self.assertEqual([111L], cd.cc_ids) |
| 235 |
| 236 def testProcessDeleteComponent(self): |
| 237 self.servlet._ProcessDeleteComponent(self.mr, self.cd) |
| 238 self.assertIsNone( |
| 239 tracker_bizobj.FindComponentDef('BackEnd', self.config)) |
| 240 |
| 241 def testProcessEditComponent(self): |
| 242 post_data = fake.PostData( |
| 243 leaf_name=['BackEnd'], |
| 244 docstring=['This is where the magic happens'], |
| 245 deprecated=[True], |
| 246 admins=['a@example.com'], |
| 247 cc=['a@example.com']) |
| 248 |
| 249 self.servlet._ProcessEditComponent( |
| 250 self.mr, post_data, self.config, self.cd) |
| 251 |
| 252 self.mox.VerifyAll() |
| 253 config = self.services.config.GetProjectConfig( |
| 254 self.mr.cnxn, self.mr.project_id) |
| 255 cd = tracker_bizobj.FindComponentDef('BackEnd', config) |
| 256 self.assertEqual('BackEnd', cd.path) |
| 257 self.assertEqual( |
| 258 'This is where the magic happens', |
| 259 cd.docstring) |
| 260 self.assertEqual(True, cd.deprecated) |
| 261 self.assertEqual([111L], cd.admin_ids) |
| 262 self.assertEqual([111L], cd.cc_ids) |
| 263 # Assert that creator and created were not updated. |
| 264 self.assertEqual(122L, cd.creator_id) |
| 265 self.assertEqual(100000, cd.created) |
| 266 # Assert that modifier and modified were updated. |
| 267 self.assertEqual(122L, cd.modifier_id) |
| 268 self.assertTrue(cd.modified > 10000000) |
| 269 |
| 270 def testProcessEditComponent_RenameWithSubComponents(self): |
| 271 subcd_1 = tracker_bizobj.MakeComponentDef( |
| 272 2, self.project.project_id, 'BackEnd>Worker1', 'doc', False, [], [111L], |
| 273 0, 125L, 3, 126L) |
| 274 subcd_2 = tracker_bizobj.MakeComponentDef( |
| 275 3, self.project.project_id, 'BackEnd>Worker2', 'doc', False, [], [111L], |
| 276 0, 125L, 4, 127L) |
| 277 self.config.component_defs.extend([subcd_1, subcd_2]) |
| 278 |
| 279 self.mox.StubOutWithMock(filterrules_helpers, 'RecomputeAllDerivedFields') |
| 280 filterrules_helpers.RecomputeAllDerivedFields( |
| 281 self.mr.cnxn, self.services, self.mr.project, self.config) |
| 282 self.mox.ReplayAll() |
| 283 post_data = fake.PostData( |
| 284 leaf_name=['BackEnds'], |
| 285 docstring=['This is where the magic happens'], |
| 286 deprecated=[True], |
| 287 admins=['a@example.com'], |
| 288 cc=['a@example.com']) |
| 289 |
| 290 self.servlet._ProcessEditComponent( |
| 291 self.mr, post_data, self.config, self.cd) |
| 292 |
| 293 self.mox.VerifyAll() |
| 294 config = self.services.config.GetProjectConfig( |
| 295 self.mr.cnxn, self.mr.project_id) |
| 296 cd = tracker_bizobj.FindComponentDef('BackEnds', config) |
| 297 self.assertEqual('BackEnds', cd.path) |
| 298 subcd_1 = tracker_bizobj.FindComponentDef('BackEnds>Worker1', config) |
| 299 self.assertEqual('BackEnds>Worker1', subcd_1.path) |
| 300 # Assert that creator and modifier have not changed for subcd_1. |
| 301 self.assertEqual(125L, subcd_1.creator_id) |
| 302 self.assertEqual(0, subcd_1.created) |
| 303 self.assertEqual(126L, subcd_1.modifier_id) |
| 304 self.assertEqual(3, subcd_1.modified) |
| 305 |
| 306 subcd_2 = tracker_bizobj.FindComponentDef('BackEnds>Worker2', config) |
| 307 self.assertEqual('BackEnds>Worker2', subcd_2.path) |
| 308 # Assert that creator and modifier have not changed for subcd_2. |
| 309 self.assertEqual(125L, subcd_2.creator_id) |
| 310 self.assertEqual(0, subcd_2.created) |
| 311 self.assertEqual(127L, subcd_2.modifier_id) |
| 312 self.assertEqual(4, subcd_2.modified) |
| 313 |
| 314 |
| 315 if __name__ == '__main__': |
| 316 unittest.main() |
OLD | NEW |