[NTP Snippets] Fetcher: only download snippets that have a thumbnail

components/ntp_snippets/ntp_snippets_fetcher.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/ntp_snippets_fetcher.h"
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/path_service.h"
 #include "base/strings/string_util.h"
@@ skipping 20 matching lines @@
     "https://chromereader-pa.googleapis.com/v1/fetch";
 const char kAuthorizationRequestHeaderFormat[] = "Bearer %s";
 
 const char kRequestParameterFormat[] =
     "{"
     "  \"response_detail_level\": \"STANDARD\","
     "  \"advanced_options\": {"
     "    \"local_scoring_params\": {"
     "      \"content_params\": {"
     "        \"only_return_personalized_results\": false"
+    "      },"
+    "      \"content_restricts\": {"
+    "        \"type\": \"METADATA\","
+    "        \"value\": \"ALL\""

[May, 2016/04/06 13:39:20]

Does ALL mean title, snippet, thumbnail, URL? Or would it also remove snippets
that don't have a favicon or canonical publisher name. A lot of the data I've
seen returned from ChromeReader don't have these two (though I think from
Patrick's previous talks with Newsstand we can't use that data anyway).

[Marc Treib, 2016/04/06 13:52:54]

ALL means title, snippet, and thumbnail. (Presumably URL is always there
anyway). Those are all the possible values; I guess if new metadata restricts
are added in the future, then those would also be applied. So maybe it would be
better to explicitly specify title, snippet, and thumbnail - WDYT?

[May, 2016/04/07 16:05:12]

Yeah, I think so. It would insulate us better from changes that ChromeReader
makes to their API.

[Marc Treib, 2016/04/07 16:15:52]

Done.

     "      }"
     "%s"
     "    },"
     "    \"global_scoring_params\": {"
     "      \"num_to_return\": 10"
     "    }"
     "  }"
     "}";
 
 const char kHostRestrictFormat[] =
@@ skipping 114 matching lines @@
   }
 
   std::string response;
   bool stores_result_to_string = source->GetResponseAsString(&response);
   DCHECK(stores_result_to_string);
 
   callback_list_.Notify(response);
 }
 
 }  // namespace ntp_snippets