[runtime] reduce runtime function and builtins overhead

[runtime] reduce runtime function and builtins overhead

All the counters, trace events and runtime call stats roughly create a 30%
overhead when calling into the runtime. This CL factors out the counters into
separate non-inlined functions. This way we can reduce the overhead to a
minimum and still have some useful stats without a compile-time flag.

BUG=chromium:596055
LOG=n

Committed: https://crrev.com/ceb14f8c31f69b1a2c34e955e181edf1242abc51
Cr-Commit-Position: refs/heads/master@{#35308}

[Camillo Bruni, 2016-04-06 12:54:01]

cbruni@chromium.org changed reviewers:
+ jarin@chromium.org

[Camillo Bruni, 2016-04-06 12:54:02]

PTAL.
I hope the __attributes thing works on all compilers, otherwise I will have to
push the helpers into a separate file.

[Camillo Bruni, 2016-04-06 13:06:39]

Description was changed from

==========
[runtime] reduce runtime function and builtins overhead

All the counters, trace events and runtime call stats roughly create a 30%
overhead when calling into the runtime. This CL factors out the counters into
separate non-inlined functions. This way we can reduce the overhead to a
minimum and still have some useful stats without a compile-time flag.

BUG=chromium:596055
==========

to

==========
[runtime] reduce runtime function and builtins overhead

All the counters, trace events and runtime call stats roughly create a 30%
overhead when calling into the runtime. This CL factors out the counters into
separate non-inlined functions. This way we can reduce the overhead to a
minimum and still have some useful stats without a compile-time flag.

BUG=chromium:596055
LOG=n
==========

[Camillo Bruni, 2016-04-06 13:06:44]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 13:06:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1868513002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1868513002/20001

[caitp (gmail), 2016-04-06 13:12:22]

caitpotter88@gmail.com changed reviewers:
+ caitpotter88@gmail.com

[caitp (gmail), 2016-04-06 13:12:22]

https://codereview.chromium.org/1868513002/diff/20001/src/arguments.h
File src/arguments.h (right):

https://codereview.chromium.org/1868513002/diff/20001/src/arguments.h#newcode87
src/arguments.h:87: static __attribute__((noinline)) Type Stats_##Name(         
           \
You can use the V8_NOINLINE macro for this to make msvc happy

[Camillo Bruni, 2016-04-06 13:12:53]

On 2016/04/06 at 13:12:22, caitpotter88 wrote:
> https://codereview.chromium.org/1868513002/diff/20001/src/arguments.h
> File src/arguments.h (right):
> 
>
https://codereview.chromium.org/1868513002/diff/20001/src/arguments.h#newcode87
> src/arguments.h:87: static __attribute__((noinline)) Type Stats_##Name(       
             \
> You can use the V8_NOINLINE macro for this to make msvc happy

thanks :)

[Jarin, 2016-04-06 14:34:11]

lgtm

[Camillo Bruni, 2016-04-06 15:08:11]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2016-04-06 15:08:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1868513002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1868513002/40001

[commit-bot: I haz the power, 2016-04-06 15:31:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-06 15:33:14]

Description was changed from

==========
[runtime] reduce runtime function and builtins overhead

All the counters, trace events and runtime call stats roughly create a 30%
overhead when calling into the runtime. This CL factors out the counters into
separate non-inlined functions. This way we can reduce the overhead to a
minimum and still have some useful stats without a compile-time flag.

BUG=chromium:596055
LOG=n
==========

to

==========
[runtime] reduce runtime function and builtins overhead

All the counters, trace events and runtime call stats roughly create a 30%
overhead when calling into the runtime. This CL factors out the counters into
separate non-inlined functions. This way we can reduce the overhead to a
minimum and still have some useful stats without a compile-time flag.

BUG=chromium:596055
LOG=n

Committed: https://crrev.com/ceb14f8c31f69b1a2c34e955e181edf1242abc51
Cr-Commit-Position: refs/heads/master@{#35308}
==========

[commit-bot: I haz the power, 2016-04-06 15:33:16]

Patchset 3 (id:??) landed as
https://crrev.com/ceb14f8c31f69b1a2c34e955e181edf1242abc51
Cr-Commit-Position: refs/heads/master@{#35308}