Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: net/cookies/parsed_cookie.cc

Issue 1868493002: Ignore cookies with invalid 'SameSite' attribute values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/parsed_cookie.h ('k') | net/cookies/parsed_cookie_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/parsed_cookie.cc
diff --git a/net/cookies/parsed_cookie.cc b/net/cookies/parsed_cookie.cc
index a6c1e950689b19a40ee1ae8318c55f82fa7a95b5..2175692f534a0ff8c4db3a65f898858a47da8a10 100644
--- a/net/cookies/parsed_cookie.cc
+++ b/net/cookies/parsed_cookie.cc
@@ -179,7 +179,7 @@ ParsedCookie::~ParsedCookie() {
}
bool ParsedCookie::IsValid() const {
- return !pairs_.empty();
+ return !pairs_.empty() && IsSameSiteAttributeValid();
}
CookieSameSite ParsedCookie::SameSite() const {
@@ -506,4 +506,8 @@ void ParsedCookie::ClearAttributePair(size_t index) {
pairs_.erase(pairs_.begin() + index);
}
+bool ParsedCookie::IsSameSiteAttributeValid() const {
+ return same_site_index_ == 0 || SameSite() != CookieSameSite::DEFAULT_MODE;
+}
+
} // namespace
« no previous file with comments | « net/cookies/parsed_cookie.h ('k') | net/cookies/parsed_cookie_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698