net/cookies/parsed_cookie.cc - Issue 1868493002: Ignore cookies with invalid 'SameSite' attribute values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/parsed_cookie.cc

Issue 1868493002: Ignore cookies with invalid 'SameSite' attribute values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cookies/parsed_cookie.cc

diff --git a/net/cookies/parsed_cookie.cc b/net/cookies/parsed_cookie.cc

index a6c1e950689b19a40ee1ae8318c55f82fa7a95b5..83a576770d1b9cff7b0ecdd15d549c29dfd627bc 100644

--- a/net/cookies/parsed_cookie.cc

+++ b/net/cookies/parsed_cookie.cc

@@ -179,7 +179,7 @@ ParsedCookie::~ParsedCookie() {

}

bool ParsedCookie::IsValid() const {

- return !pairs_.empty();

+ return !pairs_.empty() && SameSite() != CookieSameSite::INVALID_MODE;

}

CookieSameSite ParsedCookie::SameSite() const {

« net/cookies/cookie_constants.cc ('K') | « net/cookies/cookie_constants.cc ('k') | net/cookies/parsed_cookie_unittest.cc » ('j') | no next file with comments »