Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1868473003: Alter dm_flags.py logic flow for certain configs (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Alter dm_flags.py logic flow for certain configs to be subtractive Replace msaa4 on Shield Tablet with glmsaa4. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1868473003 Committed: https://skia.googlesource.com/skia/+/3ddf967ffeb311b3ead780aaad2368cfdf064562

Patch Set 1 #

Patch Set 2 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -32 lines) Patch
M tools/dm_flags.json View 9 chunks +13 lines, -13 lines 0 comments Download
M tools/dm_flags.py View 1 2 chunks +24 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
bsalomon
The main goal here was to stop running 'msaa4' on the Shield and run 'glmsaa4' ...
4 years, 8 months ago (2016-04-06 15:05:49 UTC) #4
mtklein
lgtm
4 years, 8 months ago (2016-04-06 15:40:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868473003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868473003/20001
4 years, 8 months ago (2016-04-06 15:53:31 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 16:22:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3ddf967ffeb311b3ead780aaad2368cfdf064562

Powered by Google App Engine
This is Rietveld 408576698