third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp - Issue 1868473002: Use PositionMoveType::GraphemeBoundary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

Issue 1868473002: Use PositionMoveType::GraphemeBoundary (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/EditingUtilities.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

index 0960b600fc7e313586d426a8e66e6e5f4c2c38a6..e9cc2e12010ec24550a924813c30a0a0267cbe2b 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertTextCommand.cpp

@@ -195,9 +195,7 @@ void InsertTextCommand::doApply(EditingState* editingState)

endPosition = insertTab(startPosition, editingState);

if (editingState->isAborted())

return;

- // TODO(yosin) We should use |PositionMoveType::CodePoint| for

- // |previousPositionOf()|.

- startPosition = previousPositionOf(endPosition, PositionMoveType::CodePoint);

+ startPosition = previousPositionOf(endPosition, PositionMoveType::GraphemeCluster);

if (placeholder.isNotNull())

removePlaceholderAt(placeholder);

} else {