Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1868453003: Register SkLocalMatrixImageFilter for serialization. (Closed)

Created:
4 years, 8 months ago by mtklein_C
Modified:
4 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Register SkLocalMatrixImageFilter for serialization. This fixes one of the zillions of serialize-8888 backlisted tests. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1868453003 Committed: https://skia.googlesource.com/skia/+/083b869f50d4bceea6f3088e1db2bb815de7549b

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : retry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -62 lines) Patch
M src/ports/SkGlobalInitialization_default.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/dm_flags.json View 1 2 15 chunks +0 lines, -60 lines 0 comments Download
M tools/dm_flags.py View 1 2 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
mtklein_C
4 years, 8 months ago (2016-04-06 17:48:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868453003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868453003/20001
4 years, 8 months ago (2016-04-06 17:48:36 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 8 months ago (2016-04-06 17:48:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/7635) Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, ...
4 years, 8 months ago (2016-04-06 17:49:47 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868453003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868453003/40001
4 years, 8 months ago (2016-04-06 17:59:28 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 18:16:05 UTC) #12
reed1
lgtm
4 years, 8 months ago (2016-04-06 19:20:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868453003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868453003/40001
4 years, 8 months ago (2016-04-06 19:26:15 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 19:27:10 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/083b869f50d4bceea6f3088e1db2bb815de7549b

Powered by Google App Engine
This is Rietveld 408576698