components/cronet/android/api/src/org/chromium/net/CronetEngine.java - Issue 1868433003: [Cronet] Leak NetLog instance used by CronetUrlRequestContextAdapter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

Issue 1868433003: [Cronet] Leak NetLog instance used by CronetUrlRequestContextAdapter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adjust comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

diff --git a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java

index b92afc308b3324320f0d747cd1216360dc670bcf..07e04b493ea29e9036187efbaee296b5493f3616 100644

--- a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java

+++ b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java

@@ -728,7 +728,8 @@ public abstract class CronetEngine {

public abstract void shutdown();

/**

- * Starts NetLog logging to a file. The NetLog is useful for debugging.

+ * Starts NetLog logging to a file. The NetLog will contain events emitted

+ * by all live CronetEngines. The NetLog is useful for debugging.

* The file can be viewed using a Chrome browser navigated to

* chrome://net-internals/#import

* @param fileName the complete file path. It must not be empty. If the file

« no previous file with comments | « no previous file | components/cronet/android/cronet_url_request_context_adapter.h » ('j') | no next file with comments »