Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: components/cronet/android/cronet_url_request_context_adapter.h

Issue 1868433003: [Cronet] Leak NetLog instance used by CronetUrlRequestContextAdapter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adjust comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_ 5 #ifndef COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_
6 #define COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_ 6 #define COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 // File thread should be destroyed last. 159 // File thread should be destroyed last.
160 scoped_ptr<base::Thread> file_thread_; 160 scoped_ptr<base::Thread> file_thread_;
161 161
162 // |write_to_file_observer_| and |context_| should only be accessed on 162 // |write_to_file_observer_| and |context_| should only be accessed on
163 // network thread. 163 // network thread.
164 scoped_ptr<net::WriteToFileNetLogObserver> write_to_file_observer_; 164 scoped_ptr<net::WriteToFileNetLogObserver> write_to_file_observer_;
165 165
166 // |pref_service_| should outlive the HttpServerPropertiesManager owned by 166 // |pref_service_| should outlive the HttpServerPropertiesManager owned by
167 // |context_|. 167 // |context_|.
168 scoped_ptr<PrefService> pref_service_; 168 scoped_ptr<PrefService> pref_service_;
169 scoped_ptr<net::NetLog> net_log_;
170 scoped_ptr<net::URLRequestContext> context_; 169 scoped_ptr<net::URLRequestContext> context_;
171 scoped_ptr<net::ProxyConfigService> proxy_config_service_; 170 scoped_ptr<net::ProxyConfigService> proxy_config_service_;
172 scoped_refptr<JsonPrefStore> json_pref_store_; 171 scoped_refptr<JsonPrefStore> json_pref_store_;
173 net::HttpServerPropertiesManager* http_server_properties_manager_; 172 net::HttpServerPropertiesManager* http_server_properties_manager_;
174 173
175 // |sdch_owner_| should be destroyed before |json_pref_store_|, because 174 // |sdch_owner_| should be destroyed before |json_pref_store_|, because
176 // tearing down |sdch_owner_| forces |json_pref_store_| to flush pending 175 // tearing down |sdch_owner_| forces |json_pref_store_| to flush pending
177 // writes to the disk. 176 // writes to the disk.
178 scoped_ptr<net::SdchOwner> sdch_owner_; 177 scoped_ptr<net::SdchOwner> sdch_owner_;
179 178
(...skipping 14 matching lines...) Expand all
194 #if defined(DATA_REDUCTION_PROXY_SUPPORT) 193 #if defined(DATA_REDUCTION_PROXY_SUPPORT)
195 scoped_ptr<CronetDataReductionProxy> data_reduction_proxy_; 194 scoped_ptr<CronetDataReductionProxy> data_reduction_proxy_;
196 #endif 195 #endif
197 196
198 DISALLOW_COPY_AND_ASSIGN(CronetURLRequestContextAdapter); 197 DISALLOW_COPY_AND_ASSIGN(CronetURLRequestContextAdapter);
199 }; 198 };
200 199
201 } // namespace cronet 200 } // namespace cronet
202 201
203 #endif // COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_ 202 #endif // COMPONENTS_CRONET_ANDROID_CRONET_URL_REQUEST_CONTEXT_ADAPTER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698