Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 186843002: Move ChromeShell files from chrome/android/testshell to chrome/android/shell. (Closed)

Created:
6 years, 9 months ago by aurimas (slooooooooow)
Modified:
6 years, 9 months ago
Reviewers:
nyquist
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Move ChromeShell files from chrome/android/testshell to chrome/android/shell. BUG=348137 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255258

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Reupload #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase yet again #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-7 lines, -1914 lines) Patch
A + chrome/android/shell/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/chrome_main_delegate_testshell_android.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/android/shell/chrome_main_delegate_testshell_android.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/android/shell/java/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplicationObserver.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/MenuHandler.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/TestShellPKCS11AuthenticationManager.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/TestShellTab.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/TestShellToolbar.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/signin/AccountsChangedReceiver.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/sync/AccountChooserFragment.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/sync/ChromeShellSyncAdapter.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/sync/ChromeShellSyncAdapterService.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/sync/SignoutFragment.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/java/src/org/chromium/chrome/shell/sync/SyncController.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/javatests/AndroidManifest.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/javatests/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellTestBase.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/android/shell/testshell_google_location_settings_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/android/shell/testshell_google_location_settings_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/android/testshell/DEPS View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/android/testshell/chrome_main_delegate_testshell_android.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/android/testshell/chrome_main_delegate_testshell_android.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/android/testshell/java/AndroidManifest.xml View 1 chunk +0 lines, -191 lines 0 comments Download
D chrome/android/testshell/java/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 chunk +0 lines, -307 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/ChromeShellApplicationObserver.java View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/MenuHandler.java View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/TabManager.java View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/TestShellPKCS11AuthenticationManager.java View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/TestShellTab.java View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/TestShellToolbar.java View 1 chunk +0 lines, -159 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/signin/AccountsChangedReceiver.java View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/AccountChooserFragment.java View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/ChromeShellSyncAdapter.java View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/ChromeShellSyncAdapterService.java View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/SignoutFragment.java View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/SyncController.java View 1 chunk +0 lines, -193 lines 0 comments Download
D chrome/android/testshell/javatests/AndroidManifest.xml View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/android/testshell/javatests/OWNERS View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/android/testshell/javatests/src/org/chromium/chrome/shell/ChromeShellTestBase.java View 1 chunk +0 lines, -155 lines 0 comments Download
D chrome/android/testshell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/android/testshell/testshell_google_location_settings_helper.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/android/testshell/testshell_google_location_settings_helper.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/chrome_android.gypi View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
aurimas (slooooooooow)
nyquist: PTAL
6 years, 9 months ago (2014-03-04 18:27:54 UTC) #1
nyquist
lgtm
6 years, 9 months ago (2014-03-05 18:19:30 UTC) #2
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 9 months ago (2014-03-06 02:00:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/186843002/140001
6 years, 9 months ago (2014-03-06 02:00:44 UTC) #4
aurimas (slooooooooow)
The CQ bit was unchecked by aurimas@chromium.org
6 years, 9 months ago (2014-03-06 02:08:00 UTC) #5
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 9 months ago (2014-03-06 03:45:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/186843002/140001
6 years, 9 months ago (2014-03-06 03:47:36 UTC) #7
commit-bot: I haz the power
Change committed as 255258
6 years, 9 months ago (2014-03-06 05:34:04 UTC) #8
navabi
6 years, 9 months ago (2014-03-06 08:07:12 UTC) #9
Message was sent while issue was closed. 
On 2014/03/06 05:34:04, I haz the power (commit-bot) wrote:
> Change committed as 255258

Looks like you got it. How did you get it to work? Did you manual do a git try
and specify the revision like we talked about?

Powered by Google App Engine
This is Rietveld 408576698