Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-conn-type.html

Issue 1868413002: Add about:flags support for doc.write script blocking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-conn-type.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-conn-type.html b/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-conn-type.html
index 99854a8d8ca5a0b54c12469b6e7e813d523a2b74..913f4af0b8218f231e5b9bae78a8bb591b41851c 100644
--- a/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-conn-type.html
+++ b/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-conn-type.html
@@ -6,14 +6,14 @@
var jsLoaded = false;
var loadSuccess = false;
if (window.internals) {
- internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrame(true);
+ internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameOnSlowConnections(true);
internals.setNetworkStateNotifierTestOnly(true);
internals.setNetworkConnectionInfo('cellular3g', 2.0);
internals.evictAllResources();
window.addEventListener('beforeunload', function() {
internals.setNetworkStateNotifierTestOnly(false);
- internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrame(false);
+ internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrameOnSlowConnections(false);
}, false);
}
shivanisha 2016/04/11 14:26:56 May be add another test case in this file which se
Bryan McQuade 2016/04/11 16:28:30 Sure. I decided to add a new test file for this on
shivanisha 2016/04/11 16:57:56 I am good either ways. Since the test is synchron
Bryan McQuade 2016/04/11 18:15:40 I think I like this slightly better since it's eas
shivanisha 2016/04/11 19:01:07 Sounds good to me to have separate test files. Tha
document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true"></scr' + 'ipt>');

Powered by Google App Engine
This is Rietveld 408576698