Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: ui/events/platform/x11/x11_event_source_libevent.cc

Issue 1868363002: Replace scoped_ptr with std::unique_ptr in //ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scopedptrcc
Patch Set: scopedptrui: rebase-make_scoped_ptr Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/platform/x11/x11_event_source_glib.cc ('k') | ui/events/scoped_target_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/platform/x11/x11_event_source_libevent.cc
diff --git a/ui/events/platform/x11/x11_event_source_libevent.cc b/ui/events/platform/x11/x11_event_source_libevent.cc
index cf0e3d648f709df2ee8cff9f19cae457862fb291..cadf12152e244d0393caa96ea84060cea702dce9 100644
--- a/ui/events/platform/x11/x11_event_source_libevent.cc
+++ b/ui/events/platform/x11/x11_event_source_libevent.cc
@@ -7,6 +7,7 @@
#include <X11/Xlib.h>
#include <X11/extensions/XInput2.h>
+#include "base/memory/ptr_util.h"
#include "base/message_loop/message_loop.h"
#include "ui/events/event.h"
#include "ui/events/event_utils.h"
@@ -19,25 +20,25 @@ namespace ui {
namespace {
// Translates XI2 XEvent into a ui::Event.
-scoped_ptr<ui::Event> TranslateXI2EventToEvent(const XEvent& xev) {
+std::unique_ptr<ui::Event> TranslateXI2EventToEvent(const XEvent& xev) {
EventType event_type = EventTypeFromXEvent(xev);
switch (event_type) {
case ET_KEY_PRESSED:
case ET_KEY_RELEASED:
- return make_scoped_ptr(new KeyEvent(event_type,
- KeyboardCodeFromXKeyEvent(&xev),
- EventFlagsFromXEvent(xev)));
+ return base::WrapUnique(new KeyEvent(event_type,
+ KeyboardCodeFromXKeyEvent(&xev),
+ EventFlagsFromXEvent(xev)));
case ET_MOUSE_PRESSED:
case ET_MOUSE_MOVED:
case ET_MOUSE_DRAGGED:
case ET_MOUSE_RELEASED:
- return make_scoped_ptr(
+ return base::WrapUnique(
new MouseEvent(event_type, EventLocationFromXEvent(xev),
EventSystemLocationFromXEvent(xev),
EventTimeFromXEvent(xev), EventFlagsFromXEvent(xev),
GetChangedMouseButtonFlagsFromXEvent(xev)));
case ET_MOUSEWHEEL:
- return make_scoped_ptr(new MouseWheelEvent(
+ return base::WrapUnique(new MouseWheelEvent(
GetMouseWheelOffsetFromXEvent(xev), EventLocationFromXEvent(xev),
EventSystemLocationFromXEvent(xev), EventTimeFromXEvent(xev),
EventFlagsFromXEvent(xev),
@@ -47,7 +48,7 @@ scoped_ptr<ui::Event> TranslateXI2EventToEvent(const XEvent& xev) {
float x_offset, y_offset, x_offset_ordinal, y_offset_ordinal;
GetFlingDataFromXEvent(xev, &x_offset, &y_offset, &x_offset_ordinal,
&y_offset_ordinal, nullptr);
- return make_scoped_ptr(new ScrollEvent(
+ return base::WrapUnique(new ScrollEvent(
event_type, EventLocationFromXEvent(xev), EventTimeFromXEvent(xev),
EventFlagsFromXEvent(xev), x_offset, y_offset, x_offset_ordinal,
y_offset_ordinal, 0));
@@ -57,7 +58,7 @@ scoped_ptr<ui::Event> TranslateXI2EventToEvent(const XEvent& xev) {
int finger_count;
GetScrollOffsetsFromXEvent(xev, &x_offset, &y_offset, &x_offset_ordinal,
&y_offset_ordinal, &finger_count);
- return make_scoped_ptr(new ScrollEvent(
+ return base::WrapUnique(new ScrollEvent(
event_type, EventLocationFromXEvent(xev), EventTimeFromXEvent(xev),
EventFlagsFromXEvent(xev), x_offset, y_offset, x_offset_ordinal,
y_offset_ordinal, finger_count));
@@ -66,7 +67,7 @@ scoped_ptr<ui::Event> TranslateXI2EventToEvent(const XEvent& xev) {
case ET_TOUCH_PRESSED:
case ET_TOUCH_CANCELLED:
case ET_TOUCH_RELEASED:
- return make_scoped_ptr(
+ return base::WrapUnique(
new TouchEvent(event_type, EventLocationFromXEvent(xev),
GetTouchIdFromXEvent(xev), EventTimeFromXEvent(xev)));
case ET_UNKNOWN:
@@ -78,7 +79,7 @@ scoped_ptr<ui::Event> TranslateXI2EventToEvent(const XEvent& xev) {
}
// Translates a XEvent into a ui::Event.
-scoped_ptr<ui::Event> TranslateXEventToEvent(const XEvent& xev) {
+std::unique_ptr<ui::Event> TranslateXEventToEvent(const XEvent& xev) {
int flags = EventFlagsFromXEvent(xev);
switch (xev.type) {
case LeaveNotify:
@@ -87,27 +88,27 @@ scoped_ptr<ui::Event> TranslateXEventToEvent(const XEvent& xev) {
// not real mouse move event.
if (xev.type == EnterNotify)
flags |= EF_IS_SYNTHESIZED;
- return make_scoped_ptr(
+ return base::WrapUnique(
new MouseEvent(ET_MOUSE_MOVED, EventLocationFromXEvent(xev),
EventSystemLocationFromXEvent(xev),
EventTimeFromXEvent(xev), flags, 0));
case KeyPress:
case KeyRelease:
- return make_scoped_ptr(new KeyEvent(
+ return base::WrapUnique(new KeyEvent(
EventTypeFromXEvent(xev), KeyboardCodeFromXKeyEvent(&xev), flags));
case ButtonPress:
case ButtonRelease: {
switch (EventTypeFromXEvent(xev)) {
case ET_MOUSEWHEEL:
- return make_scoped_ptr(new MouseWheelEvent(
+ return base::WrapUnique(new MouseWheelEvent(
GetMouseWheelOffsetFromXEvent(xev), EventLocationFromXEvent(xev),
EventSystemLocationFromXEvent(xev), EventTimeFromXEvent(xev),
flags, 0));
case ET_MOUSE_PRESSED:
case ET_MOUSE_RELEASED:
- return make_scoped_ptr(new MouseEvent(
+ return base::WrapUnique(new MouseEvent(
EventTypeFromXEvent(xev), EventLocationFromXEvent(xev),
EventSystemLocationFromXEvent(xev), EventTimeFromXEvent(xev),
flags, GetChangedMouseButtonFlagsFromXEvent(xev)));
@@ -146,7 +147,7 @@ void X11EventSourceLibevent::RemoveXEventDispatcher(
}
void X11EventSourceLibevent::ProcessXEvent(XEvent* xevent) {
- scoped_ptr<ui::Event> translated_event = TranslateXEventToEvent(*xevent);
+ std::unique_ptr<ui::Event> translated_event = TranslateXEventToEvent(*xevent);
if (translated_event) {
DispatchEvent(translated_event.get());
} else {
« no previous file with comments | « ui/events/platform/x11/x11_event_source_glib.cc ('k') | ui/events/scoped_target_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698