ui/wm/core/visibility_controller_unittest.cc - Issue 1868363002: Replace scoped_ptr with std::unique_ptr in //ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/wm/core/visibility_controller_unittest.cc

Issue 1868363002: Replace scoped_ptr with std::unique_ptr in //ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scopedptrcc

Patch Set: scopedptrui: rebase-make_scoped_ptr Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/wm/core/visibility_controller_unittest.cc

diff --git a/ui/wm/core/visibility_controller_unittest.cc b/ui/wm/core/visibility_controller_unittest.cc

index 39a1d49179b8a82d9385d8598600a18deec59028..36f1bb6a7e9f0b12cf35d9ce85d1ff3afc4a7fdc 100644

--- a/ui/wm/core/visibility_controller_unittest.cc

+++ b/ui/wm/core/visibility_controller_unittest.cc

@@ -32,7 +32,7 @@ TEST_F(VisibilityControllerTest, AnimateTransparencyToZeroAndHideHides) {

SetChildWindowVisibilityChangesAnimated(root_window());

aura::test::TestWindowDelegate d;

- scoped_ptr<aura::Window> window(aura::test::CreateTestWindowWithDelegate(

+ std::unique_ptr<aura::Window> window(aura::test::CreateTestWindowWithDelegate(

&d, -2, gfx::Rect(0, 0, 50, 50), root_window()));

ui::ScopedLayerAnimationSettings settings(window->layer()->GetAnimator());

settings.SetTransitionDuration(base::TimeDelta::FromMilliseconds(5));

@@ -65,7 +65,7 @@ TEST_F(VisibilityControllerTest, SetWindowVisibilityChagnesAnimated) {

aura::client::SetVisibilityClient(root_window(), &controller);

aura::test::TestWindowDelegate d;

- scoped_ptr<aura::Window> window(aura::test::CreateTestWindowWithDelegate(

+ std::unique_ptr<aura::Window> window(aura::test::CreateTestWindowWithDelegate(

&d, -2, gfx::Rect(0, 0, 50, 50), root_window()));

// Test using Show animation because Hide animation detaches the window's

// layer.

« no previous file with comments | « ui/wm/core/transient_window_stacking_client_unittest.cc ('k') | ui/wm/core/window_animations.cc » ('j') | no next file with comments »