Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Side by Side Diff: ui/events/test/test_event_target.cc

Issue 1868363002: Replace scoped_ptr with std::unique_ptr in //ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scopedptrcc
Patch Set: scopedptrui: rebase-make_scoped_ptr Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/events/test/test_event_target.h ('k') | ui/events/x/events_x_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/events/test/test_event_target.h" 5 #include "ui/events/test/test_event_target.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h"
9 #include "ui/events/event.h" 10 #include "ui/events/event.h"
10 #include "ui/events/event_target_iterator.h" 11 #include "ui/events/event_target_iterator.h"
11 #include "ui/events/event_targeter.h" 12 #include "ui/events/event_targeter.h"
12 13
13 namespace ui { 14 namespace ui {
14 namespace test { 15 namespace test {
15 16
16 TestEventTarget::TestEventTarget() 17 TestEventTarget::TestEventTarget()
17 : parent_(NULL), 18 : parent_(NULL),
18 mark_events_as_handled_(false), 19 mark_events_as_handled_(false),
19 recorder_(NULL), 20 recorder_(NULL),
20 target_name_("unknown") { 21 target_name_("unknown") {
21 SetTargetHandler(this); 22 SetTargetHandler(this);
22 } 23 }
23 TestEventTarget::~TestEventTarget() {} 24 TestEventTarget::~TestEventTarget() {}
24 25
25 void TestEventTarget::AddChild(scoped_ptr<TestEventTarget> child) { 26 void TestEventTarget::AddChild(std::unique_ptr<TestEventTarget> child) {
26 TestEventTarget* child_r = child.get(); 27 TestEventTarget* child_r = child.get();
27 if (child->parent()) { 28 if (child->parent()) {
28 AddChild(child->parent()->RemoveChild(child.release())); 29 AddChild(child->parent()->RemoveChild(child.release()));
29 } else { 30 } else {
30 children_.push_back(std::move(child)); 31 children_.push_back(std::move(child));
31 } 32 }
32 child_r->set_parent(this); 33 child_r->set_parent(this);
33 } 34 }
34 35
35 scoped_ptr<TestEventTarget> TestEventTarget::RemoveChild(TestEventTarget *c) { 36 std::unique_ptr<TestEventTarget> TestEventTarget::RemoveChild(
37 TestEventTarget* c) {
36 ScopedVector<TestEventTarget>::iterator iter = std::find(children_.begin(), 38 ScopedVector<TestEventTarget>::iterator iter = std::find(children_.begin(),
37 children_.end(), 39 children_.end(),
38 c); 40 c);
39 if (iter != children_.end()) { 41 if (iter != children_.end()) {
40 children_.weak_erase(iter); 42 children_.weak_erase(iter);
41 c->set_parent(NULL); 43 c->set_parent(NULL);
42 return make_scoped_ptr(c); 44 return base::WrapUnique(c);
43 } 45 }
44 return nullptr; 46 return nullptr;
45 } 47 }
46 48
47 void TestEventTarget::SetEventTargeter(scoped_ptr<EventTargeter> targeter) { 49 void TestEventTarget::SetEventTargeter(
50 std::unique_ptr<EventTargeter> targeter) {
48 targeter_ = std::move(targeter); 51 targeter_ = std::move(targeter);
49 } 52 }
50 53
51 bool TestEventTarget::DidReceiveEvent(ui::EventType type) const { 54 bool TestEventTarget::DidReceiveEvent(ui::EventType type) const {
52 return received_.count(type) > 0; 55 return received_.count(type) > 0;
53 } 56 }
54 57
55 void TestEventTarget::ResetReceivedEvents() { 58 void TestEventTarget::ResetReceivedEvents() {
56 received_.clear(); 59 received_.clear();
57 } 60 }
58 61
59 //////////////////////////////////////////////////////////////////////////////// 62 ////////////////////////////////////////////////////////////////////////////////
60 // TestEventTarget, protected 63 // TestEventTarget, protected
61 64
62 bool TestEventTarget::CanAcceptEvent(const ui::Event& event) { 65 bool TestEventTarget::CanAcceptEvent(const ui::Event& event) {
63 return true; 66 return true;
64 } 67 }
65 68
66 EventTarget* TestEventTarget::GetParentTarget() { 69 EventTarget* TestEventTarget::GetParentTarget() {
67 return parent_; 70 return parent_;
68 } 71 }
69 72
70 scoped_ptr<EventTargetIterator> TestEventTarget::GetChildIterator() const { 73 std::unique_ptr<EventTargetIterator> TestEventTarget::GetChildIterator() const {
71 return make_scoped_ptr( 74 return base::WrapUnique(
72 new EventTargetIteratorImpl<TestEventTarget>(children_.get())); 75 new EventTargetIteratorImpl<TestEventTarget>(children_.get()));
73 } 76 }
74 77
75 EventTargeter* TestEventTarget::GetEventTargeter() { 78 EventTargeter* TestEventTarget::GetEventTargeter() {
76 return targeter_.get(); 79 return targeter_.get();
77 } 80 }
78 81
79 void TestEventTarget::OnEvent(Event* event) { 82 void TestEventTarget::OnEvent(Event* event) {
80 if (recorder_) 83 if (recorder_)
81 recorder_->push_back(target_name_); 84 recorder_->push_back(target_name_);
82 received_.insert(event->type()); 85 received_.insert(event->type());
83 EventHandler::OnEvent(event); 86 EventHandler::OnEvent(event);
84 if (!event->handled() && mark_events_as_handled_) 87 if (!event->handled() && mark_events_as_handled_)
85 event->SetHandled(); 88 event->SetHandled();
86 } 89 }
87 90
88 //////////////////////////////////////////////////////////////////////////////// 91 ////////////////////////////////////////////////////////////////////////////////
89 // TestEventTarget, private 92 // TestEventTarget, private
90 93
91 bool TestEventTarget::Contains(TestEventTarget* target) const { 94 bool TestEventTarget::Contains(TestEventTarget* target) const {
92 while (target && target != this) 95 while (target && target != this)
93 target = target->parent(); 96 target = target->parent();
94 return target == this; 97 return target == this;
95 } 98 }
96 99
97 } // namespace test 100 } // namespace test
98 } // namespace ui 101 } // namespace ui
OLDNEW
« no previous file with comments | « ui/events/test/test_event_target.h ('k') | ui/events/x/events_x_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698