Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1868333002:
Add some benches for SkArithmeticMode. (Closed)
|
Created:
4 years, 8 months ago by Stephen White Modified:
4 years, 8 months ago Reviewers:
mtklein CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionAdd some benches for SkArithmeticMode.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1868333002
Committed: https://skia.googlesource.com/skia/+/7adf9c1dd27323f60553aa5d8ffd4db9f92b95da
Patch Set 1 #Patch Set 2 : Fix formatting #Patch Set 3 : Speculative win32 fix #Messages
Total messages: 18 (10 generated)
Description was changed from ========== Add some benches for SkArithmeticMode. BUG=skia: ========== to ========== Add some benches for SkArithmeticMode. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add some benches for SkArithmeticMode. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add some benches for SkArithmeticMode. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
senorblanco@chromium.org changed reviewers: + mtklein@google.com
mtklein: PTAL. Thanks!
The CQ bit was checked by mtklein@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868333002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by senorblanco@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868333002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by senorblanco@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com Link to the patchset: https://codereview.chromium.org/1868333002/#ps40001 (title: "Speculative win32 fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868333002/40001
Message was sent while issue was closed.
Description was changed from ========== Add some benches for SkArithmeticMode. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add some benches for SkArithmeticMode. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/7adf9c1dd27323f60553aa5d8ffd4db9f92b95da ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/7adf9c1dd27323f60553aa5d8ffd4db9f92b95da |
