Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1868313002:
git cl upload: commit subject is default patchset title (Closed)
|
Created:
4 years, 8 months ago by nodir Modified:
4 years, 6 months ago CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Target Ref:
refs/heads/master Project:
depot_tools Visibility:
Public. |
Descriptiongit cl upload: commit subject is default patchset title
git cl upload asks the user to provide a patchset title.
If the user makes a commit per patchset, the subject of the commit may
be exactly what patchset title should be.
R=dnj@chromium.org, vadimsh@chromium.org
BUG=582419
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/7aafc3f4adca9d61017a95b9a8e53e7c4ac4ce4a
Patch Set 1 #Patch Set 2 : move strip #
Total comments: 2
Patch Set 3 : s/Current/MostRecent/ #Messages
Total messages: 21 (9 generated)
Description was changed from ========== git cl upload: commit subject is default patchset title git cl upload asks the user to provide a patchset title. If the user makes a commit per patchset, the subject of the commit may be exactly what patchset title should be. R=dnj@chromium.org BUG= ========== to ========== git cl upload: commit subject is default patchset title git cl upload asks the user to provide a patchset title. If the user makes a commit per patchset, the subject of the commit may be exactly what patchset title should be. R=dnj@chromium.org, vadimsh@chromium.org BUG= ==========
nodir@chromium.org changed reviewers: + vadimsh@chromium.org
Patchset #2 (id:20001) has been deleted
PTAL
Description was changed from ========== git cl upload: commit subject is default patchset title git cl upload asks the user to provide a patchset title. If the user makes a commit per patchset, the subject of the commit may be exactly what patchset title should be. R=dnj@chromium.org, vadimsh@chromium.org BUG= ========== to ========== git cl upload: commit subject is default patchset title git cl upload asks the user to provide a patchset title. If the user makes a commit per patchset, the subject of the commit may be exactly what patchset title should be. R=dnj@chromium.org, vadimsh@chromium.org BUG=582419 ==========
tandrii@chromium.org changed reviewers: + tandrii@chromium.org
drive-by review from tired git cl hacker: can you add a test?
agable@chromium.org changed reviewers: + agable@chromium.org
LGTM % nit https://codereview.chromium.org/1868313002/diff/40001/third_party/upload.py File third_party/upload.py (right): https://codereview.chromium.org/1868313002/diff/40001/third_party/upload.py#n... third_party/upload.py:1048: def GetCurrentCommitSummary(self): nit: s/Current/MostRecent/ feel free to ignore
sorry tandrii. I've tested it locally. It works, I promise https://codereview.chromium.org/1868313002/diff/40001/third_party/upload.py File third_party/upload.py (right): https://codereview.chromium.org/1868313002/diff/40001/third_party/upload.py#n... third_party/upload.py:1048: def GetCurrentCommitSummary(self): On 2016/06/09 22:15:14, agable wrote: > nit: s/Current/MostRecent/ > > feel free to ignore Done.
The CQ bit was checked by nodir@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from agable@chromium.org Link to the patchset: https://codereview.chromium.org/1868313002/#ps60001 (title: "s/Current/MostRecent/")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868313002/60001
Message was sent while issue was closed.
Description was changed from ========== git cl upload: commit subject is default patchset title git cl upload asks the user to provide a patchset title. If the user makes a commit per patchset, the subject of the commit may be exactly what patchset title should be. R=dnj@chromium.org, vadimsh@chromium.org BUG=582419 ========== to ========== git cl upload: commit subject is default patchset title git cl upload asks the user to provide a patchset title. If the user makes a commit per patchset, the subject of the commit may be exactly what patchset title should be. R=dnj@chromium.org, vadimsh@chromium.org BUG=582419 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/7aafc3f4adca9d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/7aafc3f4adca9d...
Message was sent while issue was closed.
oh, this is upload, yeah don't add a test. With some luck, this code will be dead in 2 years. However, have you considered adding the same to Gerrit codepath?
Message was sent while issue was closed.
On 2016/06/10 10:45:15, tandrii(chromium) wrote: > oh, this is upload, yeah don't add a test. With some luck, this code will be > dead in 2 years. > > However, have you considered adding the same to Gerrit codepath? I did not consider that, sorry
Message was sent while issue was closed.
On 2016/06/10 16:07:31, nodir wrote: > On 2016/06/10 10:45:15, tandrii(chromium) wrote: > > oh, this is upload, yeah don't add a test. With some luck, this code will be > > dead in 2 years. > > > > However, have you considered adding the same to Gerrit codepath? > > I did not consider that, sorry Also I am not sure gerrit has "patchset title" concept
Message was sent while issue was closed.
On 2016/06/10 16:09:03, nodir wrote: > On 2016/06/10 16:07:31, nodir wrote: > > On 2016/06/10 10:45:15, tandrii(chromium) wrote: > > > oh, this is upload, yeah don't add a test. With some luck, this code will be > > > dead in 2 years. > > > > > > However, have you considered adding the same to Gerrit codepath? > > > > I did not consider that, sorry > > Also I am not sure gerrit has "patchset title" concept It sorta does. In git_cl I kept them optional due to laziness: https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/git_cl....
Message was sent while issue was closed.
Thanks Nodir! I just noticed this change while uploading a patchset. Having to re-input the patchset title which is the same as a commit message I just added was one of those little things that I never noticed annoying me until it was fixed :-D
Message was sent while issue was closed.
On 2016/06/14 00:02:46, qyearsley wrote: > Thanks Nodir! I just noticed this change while uploading a patchset. Having to > re-input the patchset title which is the same as a commit message I just added > was one of those little things that I never noticed annoying me until it was > fixed :-D You are welcome |
