Test that server socket cannot reuse port

net/socket/tcp_server_socket_unittest.cc

Index: net/socket/tcp_server_socket_unittest.cc
diff --git a/net/socket/tcp_server_socket_unittest.cc b/net/socket/tcp_server_socket_unittest.cc
index fd81e550d080579f2b623e410b5622229db0bfd8..987bb978930c354a799da236fb6404f377431035 100644
--- a/net/socket/tcp_server_socket_unittest.cc
+++ b/net/socket/tcp_server_socket_unittest.cc
@@ -23,6 +23,7 @@ namespace net {
 
 namespace {
 const int kListenBacklog = 5;
+const int kListenPort = 31373;
 
 class TCPServerSocketTest : public PlatformTest {
  protected:
@@ -246,6 +247,24 @@ TEST_F(TCPServerSocketTest, AcceptIO) {
   ASSERT_EQ(message, received_message);
 }
 
+TEST_F(TCPServerSocketTest, Rebind) {
+  IPEndPoint address;
+  ParseAddress("127.0.0.1", kListenPort, &address);

[wtc, 2013/07/25 18:03:56]

Using a constant listen port may prevent another person from running
this unit test on the same machine at the same time. This could be
problematic for a shared machine such as a try bot.

I suggest the following solution:

1. Have |socket| bind to port 0, and call socket.GetLocalAddress
to get the actual port number. Then, have |conflict_socket| bind to
that port number.

This still leaves a small window (after |socket.reset(NULL)| and before
the unit test ends) when |socket| releases the port, and another user
who runs the same test may grab that port.

2. Use a port number based on process id (PID), so that different
processes will use different port numbers.

3. Use a random port number. There is still a small probability that
the port numbers will collide.

[Bei Zhang, 2013/07/26 05:10:40]

Done. I think no solution is perfect here. I cannot really assure that the port
number derived from PID will not duplicate as well, it might also conflict with
existing program.

+
+  scoped_ptr<TCPServerSocket> socket(
+      new TCPServerSocket(NULL, NetLog::Source()));
+  ASSERT_EQ(OK, socket->Listen(address, kListenBacklog));
+
+  scoped_ptr<TCPServerSocket> conflict_socket(
+      new TCPServerSocket(NULL, NetLog::Source()));
+  ASSERT_NE(OK, conflict_socket->Listen(address, kListenBacklog));
+
+  // Unbind
+  socket.reset(NULL);
+
+  ASSERT_EQ(OK, conflict_socket->Listen(address, kListenBacklog));
+}
+
 }  // namespace
 
 }  // namespace net