Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1868293002: Make converstion explicit from CFX_ByteString to uint8_t* (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make converstion explicit from CFX_ByteString to uint8_t* BUG= Committed: https://pdfium.googlesource.com/pdfium/+/cfd4d57800835011b028435e064f13c29243d6e6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -48 lines) Patch
M core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorspace.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_standard_security_handler.cpp View 8 chunks +21 lines, -21 lines 0 comments Download
M core/fxcrt/include/fx_string.h View 2 chunks +1 line, -7 lines 0 comments Download
M core/fxge/ge/fx_ge_fontmap.cpp View 4 chunks +9 lines, -8 lines 0 comments Download
M fpdfsdk/fpdf_flatten.cpp View 4 chunks +4 lines, -8 lines 0 comments Download
M xfa/fxfa/app/xfa_ffimageedit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Tom Sepez
Lei, for review. Long overdue cleanup here.
4 years, 8 months ago (2016-04-08 19:48:47 UTC) #3
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-08 20:40:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868293002/1
4 years, 8 months ago (2016-04-08 21:38:37 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 21:39:00 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/cfd4d57800835011b028435e064f13c29243...

Powered by Google App Engine
This is Rietveld 408576698