chrome/browser/ui/webui/signin/sync_confirmation_ui.cc - Issue 1868273002: Enhanced Sync Confirmation modal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/sync_confirmation_ui.cc

Issue 1868273002: Enhanced Sync Confirmation modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dan's comments + rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/signin/sync_confirmation_ui.cc

diff --git a/chrome/browser/ui/webui/signin/sync_confirmation_ui.cc b/chrome/browser/ui/webui/signin/sync_confirmation_ui.cc

index 439a7c11665836a73668a93f8d0abcb7cc7c9fa4..a3efcfd36ed99299e3332bd953251b13f04bc594 100644

--- a/chrome/browser/ui/webui/signin/sync_confirmation_ui.cc

+++ b/chrome/browser/ui/webui/signin/sync_confirmation_ui.cc

@@ -33,7 +33,13 @@ SyncConfirmationUI::SyncConfirmationUI(

source->AddLocalizedString("syncConfirmationChromeSyncTitle",

IDS_SYNC_CONFIRMATION_CHROME_SYNC_TITLE);

source->AddLocalizedString("syncConfirmationChromeSyncBody",

- IDS_SYNC_CONFIRMATION_CHROME_SYNC_BODY);

+ IDS_SYNC_CONFIRMATION_CHROME_SYNC_MESSAGE);

+ source->AddLocalizedString("syncConfirmationPersonalizeServicesTitle",

+ IDS_SYNC_CONFIRMATION_PERSONALIZE_SERVICES_TITLE);

+ source->AddLocalizedString("syncConfirmationPersonalizeServicesBody",

+ IDS_SYNC_CONFIRMATION_PERSONALIZE_SERVICES_BODY);

+ source->AddLocalizedString("syncConfirmationSyncSettingsLinkBody",

+ IDS_SYNC_CONFIRMATION_SYNC_SETTINGS_LINK_BODY);

source->AddLocalizedString("syncConfirmationConfirmLabel",

IDS_SYNC_CONFIRMATION_CONFIRM_BUTTON_LABEL);

source->AddLocalizedString("syncConfirmationUndoLabel",