chrome/browser/ui/webui/signin/login_ui_service.cc - Issue 1868273002: Enhanced Sync Confirmation modal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/login_ui_service.cc

Issue 1868273002: Enhanced Sync Confirmation modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dan's comments + rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/signin/login_ui_service.cc

diff --git a/chrome/browser/ui/webui/signin/login_ui_service.cc b/chrome/browser/ui/webui/signin/login_ui_service.cc

index 469bde9ebdc56a97484b62cf09d3f1d09648f43e..042f6c72309d17ff903ff0f99d14a0c6de0ab2d7 100644

--- a/chrome/browser/ui/webui/signin/login_ui_service.cc

+++ b/chrome/browser/ui/webui/signin/login_ui_service.cc

@@ -45,11 +45,11 @@ void LoginUIService::LoginUIClosed(LoginUI* ui) {

}

void LoginUIService::SyncConfirmationUIClosed(

- SyncConfirmationUIClosedResults results) {

+ SyncConfirmationUIClosedResult result) {

FOR_EACH_OBSERVER(

Observer,

observer_list_,

- OnSyncConfirmationUIClosed(results));

+ OnSyncConfirmationUIClosed(result));

}

void LoginUIService::UntrustedLoginUIShown() {