chrome/browser/ui/webui/options/sync_setup_handler.cc - Issue 1868273002: Enhanced Sync Confirmation modal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler.cc

Issue 1868273002: Enhanced Sync Confirmation modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dan's comments + rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/sync_setup_handler.cc

diff --git a/chrome/browser/ui/webui/options/sync_setup_handler.cc b/chrome/browser/ui/webui/options/sync_setup_handler.cc

index 32fa4578add0b5d89b136431046c3021e658e0ad..116af9641cba2897205d27f7abeb0720dc9d9718 100644

--- a/chrome/browser/ui/webui/options/sync_setup_handler.cc

+++ b/chrome/browser/ui/webui/options/sync_setup_handler.cc

@@ -201,6 +201,14 @@ void SyncSetupHandler::GetStaticLocalizedValues(

"encryptionSectionMessage",

GetStringFUTF16(IDS_SYNC_ENCRYPTION_SECTION_MESSAGE, product_name));

localized_strings->SetString(

+ "personalizeGoogleServicesTitle",

+ GetStringUTF16(IDS_SYNC_CONFIRMATION_PERSONALIZE_SERVICES_TITLE));

+ localized_strings->SetString(

+ "personalizeGoogleServicesMessage",

+ GetStringFUTF16(

+ IDS_SYNC_PERSONALIZE_GOOGLE_SERVICES_MESSAGE,

+ base::ASCIIToUTF16(chrome::kGoogleAccountActivityControlsURL)));

+ localized_strings->SetString(

"passphraseRecover",

GetStringFUTF16(

IDS_SYNC_PASSPHRASE_RECOVER,