Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2357)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Issue 1868273002: Enhanced Sync Confirmation modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Dan's comments + rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_sync_starter.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
index 079f5b9f63863fbb74fd756b670caa9981ee2645..8aeb723f22347631056d6a4e50d7e40feea652df 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
@@ -390,7 +390,7 @@ void OneClickSigninSyncStarter::UntrustedSigninConfirmed(
}
void OneClickSigninSyncStarter::OnSyncConfirmationUIClosed(
- LoginUIService::SyncConfirmationUIClosedResults results) {
+ LoginUIService::SyncConfirmationUIClosedResult result) {
if (switches::UsePasswordSeparatedSigninFlow()) {
// We didn't run this callback in AccountAddedToCookie so do it now.
@@ -398,7 +398,7 @@ void OneClickSigninSyncStarter::OnSyncConfirmationUIClosed(
sync_setup_completed_callback_.Run(SYNC_SETUP_SUCCESS);
}
- switch (results) {
+ switch (result) {
case LoginUIService::CONFIGURE_SYNC_FIRST:
content::RecordAction(
base::UserMetricsAction("Signin_Signin_WithAdvancedSyncSettings"));

Powered by Google App Engine
This is Rietveld 408576698