chrome/browser/resources/sync_confirmation/sync_confirmation.html - Issue 1868273002: Enhanced Sync Confirmation modal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/sync_confirmation/sync_confirmation.html

Issue 1868273002: Enhanced Sync Confirmation modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Dan's comments + rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/sync_confirmation/sync_confirmation.css ('k') | chrome/browser/ui/sync/one_click_signin_sync_starter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/sync_confirmation/sync_confirmation.html

diff --git a/chrome/browser/resources/sync_confirmation/sync_confirmation.html b/chrome/browser/resources/sync_confirmation/sync_confirmation.html

index 5d287a5a7d55afe2d7bccb5e624c93707d6dc332..5095cb905cbbd3ffd31ee20d1e9bddf9afa6f740 100644

--- a/chrome/browser/resources/sync_confirmation/sync_confirmation.html

+++ b/chrome/browser/resources/sync_confirmation/sync_confirmation.html

@@ -6,10 +6,16 @@

+ <style is="custom-style">

+ a {

+ color: var(--google-blue-700);

+ text-decoration: none;

+ }

+ </style>

</head>

<body>

- <div class="top-title-bar" i18n-content="syncConfirmationTitle"></div>

+ <div class="top-title-bar">$i18n{syncConfirmationTitle}</div>

@@ -38,15 +44,39 @@

</div>

- <div class="sync-message"

- i18n-values=".innerHTML:syncConfirmationChromeSyncBody"></div>

- <div class="action-container">

- <paper-button id="confirmButton"

- i18n-content="syncConfirmationConfirmLabel"></paper-button>

- <paper-button id="undoButton"

- i18n-content="syncConfirmationUndoLabel"></paper-button>

+ <div class="message-container">

+ <div id="chrome-logo" class="logo"></div>

+ <div>

+ <div class="title">$i18n{syncConfirmationChromeSyncTitle}</div>

+ <div class="body text"

+ i18n-values=".innerHTML:syncConfirmationChromeSyncBody"></div>

+ </div>

+ <div class="message-container">

+ <div id="googleg-logo" class="logo"></div>

+ <div>

+ <div class="title">

+ $i18n{syncConfirmationPersonalizeServicesTitle}

+ </div>

+ <div class="body text">

+ $i18n{syncConfirmationPersonalizeServicesBody}

+ </div>

+ <div class="message-container">

+ <div class="body"

+ i18n-values=".innerHTML:syncConfirmationSyncSettingsLinkBody">

+ </div>

</div>

+ <div class="action-container">

+ <paper-button id="confirmButton">

+ $i18n{syncConfirmationConfirmLabel}

+ </paper-button>

+ <paper-button id="undoButton">

+ $i18n{syncConfirmationUndoLabel}

+ </paper-button>

+ </div>

</div>

</body>