Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: chrome/browser/resources/options/sync_setup_overlay.js

Issue 1868273002: Enhanced Sync Confirmation modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Dan's comments + rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/sync_setup_overlay.js
diff --git a/chrome/browser/resources/options/sync_setup_overlay.js b/chrome/browser/resources/options/sync_setup_overlay.js
index 59332d260bfc57d7f887a5f333bab07a934606d8..84d12edbff45cb81801f6a886229d77956f702f1 100644
--- a/chrome/browser/resources/options/sync_setup_overlay.js
+++ b/chrome/browser/resources/options/sync_setup_overlay.js
@@ -144,6 +144,10 @@ cr.define('options', function() {
$('sync-spinner-cancel').onclick = function() {
self.closeOverlay_();
};
+ $('activity-controls').onclick = function() {
+ chrome.metricsPrivate.recordUserAction(
+ 'Signin_AccountSettings_GoogleActivityControlsClicked');
+ };
$('confirm-everything-ok').onclick = function() {
self.sendConfiguration_();
};
@@ -643,6 +647,7 @@ cr.define('options', function() {
// Hide the encryption section.
$('customize-sync-encryption-new').hidden = true;
+ $('personalize-google-services').hidden = true;
$('sync-custom-passphrase-container').hidden = true;
$('sync-existing-passphrase-container').hidden = true;
@@ -702,6 +707,7 @@ cr.define('options', function() {
$('sync-custom-passphrase-container').hidden = false;
$('sync-new-encryption-section-container').hidden = false;
$('customize-sync-encryption-new').hidden = !args.encryptAllDataAllowed;
+ $('personalize-google-services').hidden = false;
$('sync-existing-passphrase-container').hidden = true;

Powered by Google App Engine
This is Rietveld 408576698