Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: chrome/browser/ui/webui/signin/login_ui_service.h

Issue 1868273002: Enhanced Sync Confirmation modal (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Dan's comments + rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_SIGNIN_LOGIN_UI_SERVICE_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_SIGNIN_LOGIN_UI_SERVICE_H_
6 #define CHROME_BROWSER_UI_WEBUI_SIGNIN_LOGIN_UI_SERVICE_H_ 6 #define CHROME_BROWSER_UI_WEBUI_SIGNIN_LOGIN_UI_SERVICE_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/observer_list.h" 9 #include "base/observer_list.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 15 matching lines...) Expand all
26 26
27 // Invoked when the login UI should be closed. This can be invoked if the 27 // Invoked when the login UI should be closed. This can be invoked if the
28 // user takes an action that should display new login UI. 28 // user takes an action that should display new login UI.
29 virtual void CloseUI() = 0; 29 virtual void CloseUI() = 0;
30 protected: 30 protected:
31 virtual ~LoginUI() {} 31 virtual ~LoginUI() {}
32 }; 32 };
33 33
34 // Used when the sync confirmation UI is closed to signify which option was 34 // Used when the sync confirmation UI is closed to signify which option was
35 // selected by the user. 35 // selected by the user.
36 enum SyncConfirmationUIClosedResults { 36 enum SyncConfirmationUIClosedResult {
37 // Start sync immediately. 37 // Start sync immediately.
38 SYNC_WITH_DEFAULT_SETTINGS, 38 SYNC_WITH_DEFAULT_SETTINGS,
39 // Show the user the sync settings before starting sync. 39 // Show the user the sync settings before starting sync.
40 CONFIGURE_SYNC_FIRST, 40 CONFIGURE_SYNC_FIRST,
41 // The signing process was aborted, don't start sync or show settings. 41 // The signing process was aborted, don't start sync or show settings.
42 ABORT_SIGNIN, 42 ABORT_SIGNIN,
43 }; 43 };
44 44
45 // Interface for obervers of LoginUIService. 45 // Interface for obervers of LoginUIService.
46 class Observer { 46 class Observer {
47 public: 47 public:
48 // Called when a new login UI is shown. 48 // Called when a new login UI is shown.
49 // |ui| The login UI that was just shown. Will never be null. 49 // |ui| The login UI that was just shown. Will never be null.
50 virtual void OnLoginUIShown(LoginUI* ui) {} 50 virtual void OnLoginUIShown(LoginUI* ui) {}
51 51
52 // Called when a login UI is closed. 52 // Called when a login UI is closed.
53 // |ui| The login UI that was just closed; will never be null. 53 // |ui| The login UI that was just closed; will never be null.
54 virtual void OnLoginUIClosed(LoginUI* ui) {} 54 virtual void OnLoginUIClosed(LoginUI* ui) {}
55 55
56 // Called when the sync confirmation UI is closed. |results| indicates the 56 // Called when the sync confirmation UI is closed. |result| indicates the
57 // option chosen by the user in the confirmation UI. 57 // option chosen by the user in the confirmation UI.
58 virtual void OnSyncConfirmationUIClosed( 58 virtual void OnSyncConfirmationUIClosed(
59 SyncConfirmationUIClosedResults results) {} 59 SyncConfirmationUIClosedResult result) {}
60 60
61 // Called when a confirmation UI for untrusted signin is shown. 61 // Called when a confirmation UI for untrusted signin is shown.
62 virtual void OnUntrustedLoginUIShown() {} 62 virtual void OnUntrustedLoginUIShown() {}
63 63
64 protected: 64 protected:
65 virtual ~Observer() {} 65 virtual ~Observer() {}
66 }; 66 };
67 67
68 explicit LoginUIService(Profile* profile); 68 explicit LoginUIService(Profile* profile);
69 ~LoginUIService() override; 69 ~LoginUIService() override;
70 70
71 // Gets the currently active login UI, or null if no login UI is active. 71 // Gets the currently active login UI, or null if no login UI is active.
72 LoginUI* current_login_ui() const { 72 LoginUI* current_login_ui() const {
73 return ui_; 73 return ui_;
74 } 74 }
75 75
76 // |observer| The observer to add or remove; cannot be NULL. 76 // |observer| The observer to add or remove; cannot be NULL.
77 void AddObserver(Observer* observer); 77 void AddObserver(Observer* observer);
78 void RemoveObserver(Observer* observer); 78 void RemoveObserver(Observer* observer);
79 79
80 // Sets the currently active login UI. It is illegal to call this if there is 80 // Sets the currently active login UI. It is illegal to call this if there is
81 // already login UI visible. 81 // already login UI visible.
82 void SetLoginUI(LoginUI* ui); 82 void SetLoginUI(LoginUI* ui);
83 83
84 // Called when login UI is closed. If the passed UI is the current login UI, 84 // Called when login UI is closed. If the passed UI is the current login UI,
85 // sets current_login_ui() to null. 85 // sets current_login_ui() to null.
86 void LoginUIClosed(LoginUI* ui); 86 void LoginUIClosed(LoginUI* ui);
87 87
88 // Called when the sync settings confirmation UI is closed. 88 // Called when the sync confirmation UI is closed. |result| indicates the
89 void SyncConfirmationUIClosed(SyncConfirmationUIClosedResults results); 89 // option chosen by the user in the confirmation UI.
90 void SyncConfirmationUIClosed(SyncConfirmationUIClosedResult result);
90 91
91 // Called when a confirmation UI for untrusted signin is shown. 92 // Called when a confirmation UI for untrusted signin is shown.
92 void UntrustedLoginUIShown(); 93 void UntrustedLoginUIShown();
93 94
94 // Delegate to an existing login dialog if one exists. 95 // Delegate to an existing login dialog if one exists.
95 // If not, we make a new popup dialog window, and set it to 96 // If not, we make a new popup dialog window, and set it to
96 // chrome://signin to ask the user to sign in to chrome. 97 // chrome://signin to ask the user to sign in to chrome.
97 void ShowLoginPopup(); 98 void ShowLoginPopup();
98 99
99 // Displays login results. 100 // Displays login results.
100 void DisplayLoginResult(Browser* browser, const base::string16& message); 101 void DisplayLoginResult(Browser* browser, const base::string16& message);
101 102
102 // Gets the last login result set through |DisplayLoginResult|. 103 // Gets the last login result set through |DisplayLoginResult|.
103 const base::string16& GetLastLoginResult(); 104 const base::string16& GetLastLoginResult();
104 105
105 private: 106 private:
106 // Weak pointer to the currently active login UI, or null if none. 107 // Weak pointer to the currently active login UI, or null if none.
107 LoginUI* ui_; 108 LoginUI* ui_;
108 Profile* profile_; 109 Profile* profile_;
109 110
110 // List of observers. 111 // List of observers.
111 base::ObserverList<Observer> observer_list_; 112 base::ObserverList<Observer> observer_list_;
112 113
113 base::string16 last_login_result_; 114 base::string16 last_login_result_;
114 115
115 DISALLOW_COPY_AND_ASSIGN(LoginUIService); 116 DISALLOW_COPY_AND_ASSIGN(LoginUIService);
116 }; 117 };
117 118
118 #endif // CHROME_BROWSER_UI_WEBUI_SIGNIN_LOGIN_UI_SERVICE_H_ 119 #endif // CHROME_BROWSER_UI_WEBUI_SIGNIN_LOGIN_UI_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/options/sync_setup_handler.cc ('k') | chrome/browser/ui/webui/signin/login_ui_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698