Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 1868253002: Fetch: 'password' credentials mode should include credentials. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
index 799d030ede6a1c1f0215a04cd89679dcb73ecf7e..f38dc92e552a43869825ca47acb01de19bfedf18 100644
--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
@@ -602,11 +602,14 @@ void FetchManager::Loader::performHTTPFetch(bool corsFlag, bool corsPreflightFla
ResourceLoaderOptions resourceLoaderOptions;
resourceLoaderOptions.dataBufferingPolicy = DoNotBufferData;
if (m_request->credentials() == WebURLRequest::FetchCredentialsModeInclude
+ || m_request->credentials() == WebURLRequest::FetchCredentialsModePassword
Mike West 2016/04/08 18:49:25 *sobs*
|| (m_request->credentials() == WebURLRequest::FetchCredentialsModeSameOrigin && !corsFlag)) {
resourceLoaderOptions.allowCredentials = AllowStoredCredentials;
}
- if (m_request->credentials() == WebURLRequest::FetchCredentialsModeInclude)
+ if (m_request->credentials() == WebURLRequest::FetchCredentialsModeInclude
+ || m_request->credentials() == WebURLRequest::FetchCredentialsModePassword) {
Mike West 2016/04/08 18:49:25 *more sobs*
resourceLoaderOptions.credentialsRequested = ClientRequestedCredentials;
+ }
resourceLoaderOptions.securityOrigin = m_request->origin().get();
ThreadableLoaderOptions threadableLoaderOptions;

Powered by Google App Engine
This is Rietveld 408576698