Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1698)

Unified Diff: build/android/download_doclava.py

Issue 1868203002: Revert of Download doclava when building for Android and use to build cronet Javadocs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | components/cronet/android/api/build.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/download_doclava.py
diff --git a/build/android/download_doclava.py b/build/android/download_doclava.py
deleted file mode 100755
index f9f9ea2f4c4a4ab039347a8a75a7f9e45bb94bff..0000000000000000000000000000000000000000
--- a/build/android/download_doclava.py
+++ /dev/null
@@ -1,39 +0,0 @@
-#!/usr/bin/env python
-# Copyright 2016 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-"""Minimal tool to download doclava from Google storage when building for
-Android."""
-
-import os
-import subprocess
-import sys
-
-
-# Its existence signifies an Android checkout.
-ANDROID_ONLY_DIR = os.path.join(os.path.dirname(os.path.abspath(__file__)),
- os.pardir, os.pardir,
- 'third_party', 'android_tools')
-
-
-def main():
- # Some Windows bots inadvertently have third_party/android_tools installed,
- # but are unable to run download_from_google_storage because depot_tools
- # is not in their path, so avoid failure and bail.
- if sys.platform == 'win32':
- return 0
- if not os.path.exists(ANDROID_ONLY_DIR):
- return 0
- subprocess.check_call([
- 'download_from_google_storage',
- '--no_resume',
- '--no_auth',
- '--bucket', 'chromium-doclava',
- '--extract',
- '-s',
- os.path.join('src', 'buildtools', 'android', 'doclava.tar.gz.sha1')])
- return 0
-
-if __name__ == '__main__':
- sys.exit(main())
« no previous file with comments | « DEPS ('k') | components/cronet/android/api/build.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698