Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1868203002: Revert of Download doclava when building for Android and use to build cronet Javadocs (Closed)

Created:
4 years, 8 months ago by pauljensen
Modified:
4 years, 8 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Download doclava when building for Android and use to build cronet Javadocs (patchset #10 id:180001 of https://codereview.chromium.org/1557233003/ ) Reason for revert: Passes once and then subsequent builds fail with "javadoc: error - Cannot find doclet class com.google.doclava.Doclava". My guess is download_from_google_storage is somehow not extracting the next time, and some script is clearing the extracted directory but not the downloaded archive. BUG=601800 Original issue's description: > [Cronet] Use doclava to build Cronet Javadocs > > During "gclient runhooks", download doclava from Google Storage when building for Android. > Switching to doclava allows using the @hide tag instead of > the @deprecated tag which leads to build warnings. > Doclava does not have a nodeprecated option so deprecated > types are @hide'd. > > BUG=539519 > > Committed: https://crrev.com/62bd31bc7e6d863e87e167e4a6701b64cf584a54 > Cr-Commit-Position: refs/heads/master@{#386077} TBR=mikecase@chromium.org,agrieve@chromium.org,xunjieli@chromium.org,jbudorick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=539519 Committed: https://crrev.com/8151567e903ccf8af49d97ee633f8126eb02d01f Cr-Commit-Position: refs/heads/master@{#386088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -119 lines) Patch
M DEPS View 1 chunk +0 lines, -8 lines 0 comments Download
D build/android/download_doclava.py View 1 chunk +0 lines, -39 lines 0 comments Download
M components/cronet/android/api/build.xml View 2 chunks +6 lines, -12 lines 0 comments Download
A components/cronet/android/api/package-list View 1 chunk +14 lines, -0 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java View 1 chunk +2 lines, -1 line 0 comments Download
M components/cronet/android/api/src/org/chromium/net/CronetEngine.java View 21 chunks +52 lines, -46 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/NetworkQualityRttListener.java View 2 chunks +3 lines, -2 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/NetworkQualityThroughputListener.java View 2 chunks +3 lines, -2 lines 0 comments Download
M components/cronet/android/api/src/org/chromium/net/UrlRequest.java View 8 chunks +7 lines, -8 lines 0 comments Download
M components/cronet/tools/generate_javadoc.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
pauljensen
Created Revert of Download doclava when building for Android and use to build cronet Javadocs
4 years, 8 months ago (2016-04-08 15:46:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868203002/1
4 years, 8 months ago (2016-04-08 15:46:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 15:47:45 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 15:50:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8151567e903ccf8af49d97ee633f8126eb02d01f
Cr-Commit-Position: refs/heads/master@{#386088}

Powered by Google App Engine
This is Rietveld 408576698