Revert "Parse more user script info out of the manifest and expose"

chrome/browser/extensions/extension_protocols.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_protocols.h"
 
 #include "base/string_util.h"
-#include "chrome/browser/extensions/extension.h"
 #include "chrome/browser/net/chrome_url_request_context.h"
 #include "googleurl/src/url_util.h"
 #include "net/base/net_util.h"
 #include "net/url_request/url_request_file_job.h"
 
 const char kExtensionURLScheme[] = "chrome-extension";
 const char kUserScriptURLScheme[] = "chrome-user-script";
 
+FilePath GetPathForExtensionResource(const FilePath& extension_path,
+                                     const std::string& url_path) {
+  DCHECK(extension_path.IsAbsolute());
+  DCHECK(url_path.length() > 0 && url_path[0] == '/');
+
+  // Build up a file:// URL and convert that back to a FilePath.  This avoids
+  // URL encoding and path separator issues.
+
+  // Convert the extension's root to a file:// URL.
+  GURL extension_url = net::FilePathToFileURL(extension_path);
+  if (!extension_url.is_valid())
+    return FilePath();
+
+  // Append the requested path.
+  GURL::Replacements replacements;
+  std::string new_path(extension_url.path());
+  new_path += url_path;
+  replacements.SetPathStr(new_path);
+  GURL file_url = extension_url.ReplaceComponents(replacements);
+  if (!file_url.is_valid())
+    return FilePath();
+
+  // Convert the result back to a FilePath.
+  FilePath ret_val;
+  if (!net::FileURLToFilePath(file_url, &ret_val))
+    return FilePath();
+
+  // Double-check that the path we ended up with is actually inside the
+  // extension root. We can do this with a simple prefix match because:
+  // a) We control the prefix on both sides, and they should match.
+  // b) GURL normalizes things like "../" and "//" before it gets to us.
+  if (ret_val.value().find(extension_path.value() +
+                           FilePath::kSeparators[0]) != 0)
+    return FilePath();
+
+  return ret_val;
+}
+
 // Factory registered with URLRequest to create URLRequestJobs for extension://
 // URLs.
 static URLRequestJob* CreateExtensionURLRequestJob(URLRequest* request,
                                                    const std::string& scheme) {
   ChromeURLRequestContext* context =
       static_cast<ChromeURLRequestContext*>(request->context());
 
   // chrome-extension://extension-id/resource/path.js
   FilePath directory_path = context->GetPathForExtension(request->url().host());
   if (directory_path.value().empty())
     return NULL;
 
   std::string resource = request->url().path();
-  FilePath path = Extension::GetResourcePath(directory_path, resource);
+  FilePath path = GetPathForExtensionResource(directory_path, resource);
 
   return new URLRequestFileJob(request, path);
 }
 
 // Factory registered with URLRequest to create URLRequestJobs for
 // chrome-user-script:/ URLs.
 static URLRequestJob* CreateUserScriptURLRequestJob(URLRequest* request,
                                                     const std::string& scheme) {
   ChromeURLRequestContext* context =
       static_cast<ChromeURLRequestContext*>(request->context());
 
   // chrome-user-script:/user-script-name.user.js
   FilePath directory_path = context->user_script_dir_path();
   std::string resource = request->url().path();
 
-  FilePath path = Extension::GetResourcePath(directory_path, resource);
+  FilePath path = GetPathForExtensionResource(directory_path, resource);
   return new URLRequestFileJob(request, path);
 }
 
 void RegisterExtensionProtocols() {
   // Being a standard scheme allows us to resolve relative paths. This is used
   // by extensions, but not by standalone user scripts.
   url_util::AddStandardScheme(kExtensionURLScheme);
 
   URLRequest::RegisterProtocolFactory(kExtensionURLScheme,
                                       &CreateExtensionURLRequestJob);
   URLRequest::RegisterProtocolFactory(kUserScriptURLScheme,
                                       &CreateUserScriptURLRequestJob);
 }