Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1868053002: [Blimp Engine] BlimpImageSerializationProcessor handles kOpaque_SkAlphaType and kUnpremul_SkAlphaTy… (Closed)

Created:
4 years, 8 months ago by haibinlu
Modified:
4 years, 8 months ago
Reviewers:
nyquist
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blimp Engine] BlimpImageSerializationProcessor handles kOpaque_SkAlphaType and kUnpremul_SkAlphaType Te bug is caused by kOpaque_SkAlphaType. But handling kUnpremul_SkAlphaType is different. BUG=600872 Committed: https://crrev.com/7ca1a912c969748f924b10d68147cf7f69ce625b Cr-Commit-Position: refs/heads/master@{#386153}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M blimp/common/compositor/blimp_image_serialization_processor.cc View 3 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
haibinlu
4 years, 8 months ago (2016-04-07 21:44:22 UTC) #2
nyquist
lgtm
4 years, 8 months ago (2016-04-08 18:10:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1868053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1868053002/1
4 years, 8 months ago (2016-04-08 18:11:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 18:54:15 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 18:55:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ca1a912c969748f924b10d68147cf7f69ce625b
Cr-Commit-Position: refs/heads/master@{#386153}

Powered by Google App Engine
This is Rietveld 408576698